Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[59706] Improve BGS validation error logging #12939

Merged
merged 0 commits into from
Jun 13, 2023

Conversation

data-doge
Copy link
Contributor

@data-doge data-doge commented Jun 8, 2023

Summary

BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature ORA- and are bookended by a prepstmnt clause. See spec/fixtures/bgs/bgs_oracle_error.txt for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.

Related issue(s)

Testing done

  • Added unit tests
  • After deploy, I will monitor the logs on production to confirm that these logs are working as intended.

Screenshots

N/A

What areas of the site does it impact?

Form 686c

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 8, 2023 23:43 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 8, 2023 23:56 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 9, 2023 20:03 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 9, 2023 20:03 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:20 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:23 Inactive
@data-doge data-doge force-pushed the 59706-improve-bgs-validation-error-logging branch from f16fdf2 to 144aa80 Compare June 12, 2023 18:35
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:36 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:37 Inactive
@data-doge data-doge force-pushed the 59706-improve-bgs-validation-error-logging branch from 144aa80 to 9a6209f Compare June 12, 2023 18:37
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:38 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:42 Inactive
@data-doge data-doge force-pushed the 59706-improve-bgs-validation-error-logging branch from 9a6209f to dc92a17 Compare June 12, 2023 18:43
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:44 In progress
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:46 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 18:47 Inactive
@data-doge data-doge marked this pull request as ready for review June 12, 2023 19:12
@data-doge data-doge requested review from a team as code owners June 12, 2023 19:12
@data-doge data-doge requested a review from kylesoskin June 12, 2023 19:12
@data-doge data-doge self-assigned this Jun 12, 2023
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 19:13 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 12, 2023 19:13 Inactive
@data-doge data-doge enabled auto-merge (squash) June 12, 2023 19:21
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 13, 2023 13:40 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to 59706-improve-bgs-validation-error-logging/main/main June 13, 2023 13:40 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to 59706-improve-bgs-validation-error-logging/main/main June 13, 2023 19:30 In progress
Copy link
Contributor

@ryan-mcneil ryan-mcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@data-doge data-doge merged commit 3e2c8b3 into master Jun 13, 2023
@data-doge data-doge deleted the 59706-improve-bgs-validation-error-logging branch June 13, 2023 22:38
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature `ORA-` and are bookended by a `prepstmnt` clause. See `spec/fixtures/bgs/bgs_oracle_error.txt` for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants