-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[59706] Improve BGS validation error logging #12939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 8, 2023 23:43
Inactive
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 8, 2023 23:56
Inactive
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 9, 2023 20:03
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 9, 2023 20:03
Inactive
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:20
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:23
Inactive
data-doge
force-pushed
the
59706-improve-bgs-validation-error-logging
branch
from
June 12, 2023 18:35
f16fdf2
to
144aa80
Compare
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:36
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:37
Inactive
data-doge
force-pushed
the
59706-improve-bgs-validation-error-logging
branch
from
June 12, 2023 18:37
144aa80
to
9a6209f
Compare
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:38
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:42
Inactive
data-doge
force-pushed
the
59706-improve-bgs-validation-error-logging
branch
from
June 12, 2023 18:43
9a6209f
to
dc92a17
Compare
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:44
In progress
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:46
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 18:47
Inactive
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 19:13
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 12, 2023 19:13
Inactive
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 13, 2023 13:40
In progress
va-vfs-bot
temporarily deployed
to
59706-improve-bgs-validation-error-logging/main/main
June 13, 2023 13:40
Inactive
va-vsp-bot
requested a deployment
to
59706-improve-bgs-validation-error-logging/main/main
June 13, 2023 19:30
In progress
ryan-mcneil
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature `ORA-` and are bookended by a `prepstmnt` clause. See `spec/fixtures/bgs/bgs_oracle_error.txt` for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
BGS sometimes returns errors containing an enormous stacktrace with an oracle error. This PR logs the oracle error message and excludes everything else. These oracle errors start with the signature
ORA-
and are bookended by aprepstmnt
clause. Seespec/fixtures/bgs/bgs_oracle_error.txt
for an example. We want to log these errors separately because the original error message is so long that it obscures its only relevant information and actually breaks Sentry's UI.Related issue(s)
Testing done
Screenshots
N/A
What areas of the site does it impact?
Form 686c
Acceptance criteria
Requested Feedback