Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "API-27078-526-v2-allow-yyyy-mm-date-format-2" #12949

Merged

Conversation

rmtolmach
Copy link
Contributor

@rmtolmach rmtolmach requested review from a team as code owners June 9, 2023 18:47
@va-vsp-bot va-vsp-bot requested a deployment to revert-12927-API-27078-526-v2-allow-yyyy-mm-date-format-2/main/main June 9, 2023 18:47 In progress
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

1 Warning
⚠️ This PR changes 339 LoC (not counting whitespace/newlines).

In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding
200. Expect some delays getting reviews.

File Summary

Files

  • modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+4/-54)

  • modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb (+13/-13)

  • modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb (+17/-238)

    Note: We exclude files matching the following when considering PR size:

    *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/
    

Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

Copy link
Contributor

@rockwellwindsor-va rockwellwindsor-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks reverted.

@ericboehs ericboehs merged commit 06b7066 into master Jun 9, 2023
@ericboehs ericboehs deleted the revert-12927-API-27078-526-v2-allow-yyyy-mm-date-format-2 branch June 9, 2023 21:34
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants