-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api 27078 526 v2 allow yyyy mm date format 2 #12957
Api 27078 526 v2 allow yyyy mm date format 2 #12957
Conversation
Generated by 🚫 Danger |
modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* API-27078-526-v2-allow-yyyy-mm-date-format-2 * Updates 526.json and related json fles to be inline with new date formats * Updates valdations file to handle new date formats * Updates validation specs t handle tests with new date formats * Also adds some new tests for handling new scenarios * Updates swagger docs Changes to be committed: modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json modified: modules/claims_api/config/schemas/v2/526.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json * Merges master and updates swagger file to make sure it is inline with these changes
Adds the ability to submit approximate date values with only month and year, so that the Veteran can provide an approximate date.
This is reverting the revert on this branch done on 6/09 This branch was found to not be the cause of the issue after reverting it so this is a revert of the revert.
Summary
Related issue(s)
API-27078
Testing done
What areas of the site does it impact?
modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/example.json
modified: modules/claims_api/config/schemas/v2/request_bodies/disability_compensation/request.json
modified: modules/claims_api/spec/fixtures/v2/veterans/disability_compensation/form_526_json_api.json
modified: modules/claims_api/spec/lib/claims_api/v2/disability_compensation_pdf_mapper_spec.rb
modified: modules/claims_api/spec/requests/v2/veterans/disability_compensation_request_spec.rb
modified: spec/support/schemas/claims_api/v2/forms/disability/submission.json
Acceptance criteria