VA forms: Add form 21P-0847 #12960
Merged
VA forms: Add form 21P-0847 #12960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vsp-bot
requested a deployment
to
forms_api/add-form-21p-0847/main/main
va-vsp-bot
requested a deployment
to
forms_api/add-form-21p-0847/main/main
va-vsp-bot
requested a deployment
to
forms_api/add-form-21p-0847/main/main
va-vsp-bot
requested a deployment
to
forms_api/add-form-21p-0847/main/main
jeremy6d
suggested changes
Jun 12, 2023
|
|
||
| multistamp(generated_form_path, stamp_path) | ||
| rescue | ||
| Rails.logger.error "Failed to generate stamped file: #{e.message}" |
There was a problem hiding this comment.
I don't think this is going to work unless you make it rescue => e. And I'd really recommend capturing specific exceptions rather than any exception, but I won't block you on that.
There was a problem hiding this comment.
and maybe test exception handling if you're going to leave it so open ended?
There was a problem hiding this comment.
Thanks for calling that out! I refactored the stampers to cut down on that reused logic, added the => e and added tests for errors.
There was a problem hiding this comment.
I still left the error generic because there are a few failure points, and which one it is isn't important for us right now. I will keep that suggestion in mind.
va-vsp-bot
requested a deployment
to
forms_api/add-form-21p-0847/main/main
jeremy6d
approved these changes
Jun 12, 2023
ryan-mcneil
pushed a commit
that referenced
this pull request
Dec 11, 2023
* initially generated files for 21p-0847 * add form mappings and tests * rename files * one more name change * refactor multistamp methods and add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add form to va forms_api capabilities
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
21P-0847 (non prod)
Acceptance criteria