Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api 27427 500 claims status v2 404 #12997

Merged
merged 0 commits into from
Jun 15, 2023
Merged

Api 27427 500 claims status v2 404 #12997

merged 0 commits into from
Jun 15, 2023

Conversation

stiehlrod
Copy link
Contributor

@stiehlrod stiehlrod commented Jun 14, 2023 •
edited
Loading

Summary

  • Adjusts error handling

Related issue(s)

Testing done

  • rspec
  • Postman

What areas of the site does it impact?

modified: modules/claims_api/lib/claims_api/error/soap_error_handler.rb

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@stiehlrod stiehlrod added Lighthouse lighthouse claimsApi modules/claims_api labels Jun 14, 2023
@stiehlrod stiehlrod requested review from a team as code owners June 14, 2023 18:37
@va-vfs-bot va-vfs-bot temporarily deployed to API-27427-500-claims-status-v2-404/main/main June 14, 2023 18:43 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27427-500-claims-status-v2-404/main/main June 15, 2023 13:39 In progress
@va-vfs-bot va-vfs-bot temporarily deployed to API-27427-500-claims-status-v2-404/main/main June 15, 2023 13:39 Inactive
@va-vsp-bot va-vsp-bot requested a deployment to API-27427-500-claims-status-v2-404/main/main June 15, 2023 14:48 In progress
@stiehlrod stiehlrod merged commit fc514eb into master Jun 15, 2023
@stiehlrod stiehlrod deleted the API-27427-500-claims-status-v2-404 branch June 15, 2023 15:13
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@stiehlrod
Api 27427 500 claims status v2 404 (#12997)
b286a3d 
* Adds additional fault string to soap error handler

* Adjusts error handling to account for LH claim existence

* Removes uneeded arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FonzMP FonzMP FonzMP left review comments

@acovrig acovrig acovrig approved these changes

Assignees
No one assigned
Labels
claimsApi modules/claims_api Lighthouse lighthouse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stiehlrod @acovrig @FonzMP @va-vfs-bot @va-vsp-bot