API-26837 Clean up appeals fixture factories

[caseywilliams]

Summary

• I opened this PR separately from API-26837 Refactor appeals fixtures - part 2 #13000 since this commit put me above the limit on changed lines
• This cleans up factories for appeals models by using fixture helpers

Testing done

• Tests still pass, fixtures still load correctly

What areas of the site does it impact?

• Just appeals API tests

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[github-actions]

1 Warning

⚠️

This PR changes 262 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary Files modules/appeals_api/spec/factories/higher_level_reviews.rb (+18/-69) modules/appeals_api/spec/factories/notice_of_disagreements.rb (+19/-83) modules/appeals_api/spec/factories/supplemental_claims.rb (+15/-58) Note: We exclude files matching the following when considering PR size: *.csv, *.json, *.tsv, *.txt, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/ Big PRs are difficult to review, often become stale, and cause delays.

Generated by 🚫 Danger

[caseywilliams]

I am not sure why we use transform_values on extra headers for Supplemental Claims and Higher-Level Reviews and nowhere else, but if I remove it, it introduces spacing changes in the PDF generator specs, so I've left it in for now

[kristen-brown]

Nice! 👍