Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API-27326 Fixing my overwrites #13015

Merged
merged 0 commits into from
Jun 15, 2023
Merged

API-27326 Fixing my overwrites #13015

merged 0 commits into from
Jun 15, 2023

Conversation

rockwellwindsor-va
Copy link
Contributor

With my merge of Api 27078 526 v2 allow yyyy mm date format 2 ( I overwrote two lines of code from two previous tickets.

Summary

  • Fixes the overwrite in disability_compensation_validation.rb on line 419
  • Fixes my overwrite in 526.json line 539
  • Recompiles swagger

Related issue(s)

Overwrote change in 526.json from here API-27050
Overwrote change in disability_compensation_validation.rb from here API-27326

Testing done

  • RSpec

What areas of the site does it impact?

modified: modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified: modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
modified: modules/claims_api/config/schemas/v2/526.json

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vsp-bot va-vsp-bot requested a deployment to API-27326-fix/main/main June 15, 2023 17:22 In progress
@rockwellwindsor-va rockwellwindsor-va added the claimsApi modules/claims_api label Jun 15, 2023
@rockwellwindsor-va rockwellwindsor-va marked this pull request as ready for review June 15, 2023 17:31
@rockwellwindsor-va rockwellwindsor-va requested review from a team as code owners June 15, 2023 17:31
mchristiansonVA
mchristiansonVA approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@mchristiansonVA mchristiansonVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rockwellwindsor-va rockwellwindsor-va merged commit 1e04dad into master Jun 15, 2023
@rockwellwindsor-va rockwellwindsor-va deleted the API-27326-fix branch June 15, 2023 18:01
ryan-mcneil pushed a commit that referenced this pull request Dec 11, 2023
@rockwellwindsor-va
API-27326 Fixing my overwrites (#13015)
0cd2a5e 
* Fixes the overwrite in `disability_compensation_validation.rb` on line 419
* Fixes my overwrite in 526.json line 539
* Recompiles swagger
Changes to be committed:
	modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
	modified:   modules/claims_api/app/swagger/claims_api/v2/dev/swagger.json
	modified:   modules/claims_api/config/schemas/v2/526.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchristiansonVA mchristiansonVA mchristiansonVA approved these changes

Assignees
No one assigned
Labels
claimsApi modules/claims_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rockwellwindsor-va @mchristiansonVA @va-vfs-bot @va-vsp-bot