Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

80367 add prefill 10 7959f 1 #16499

Merged
merged 8 commits into from
May 3, 2024
Merged

80367 add prefill 10 7959f 1 #16499

merged 8 commits into from
May 3, 2024

Conversation

balexandr
Copy link
Contributor

@balexandr balexandr commented Apr 25, 2024

Add back-end logic to enable prefill for vets-website. This is an update to the original PR that could be reverted in #16481

Summary

  • Added 10-7959F-1 for FormProfile

Related issue(s)

Testing done

What areas of the site does it impact?

  • Nothing live

@va-vfs-bot va-vfs-bot temporarily deployed to 80367-add-prefill-10-7959f-1/main/main April 25, 2024 17:30 Inactive
@balexandr balexandr marked this pull request as ready for review April 25, 2024 17:37
@balexandr balexandr requested review from a team as code owners April 25, 2024 17:37
@balexandr
Copy link
Contributor Author

@RachalCassity The other ticket hasn't been reverted yet so this only has the changes to the mapping. I added a comment in the desc as to why there are no tests relating to this.

Copy link
Member

@RachalCassity RachalCassity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide testing in Form Profile Spec

Copy link
Contributor

@michaelclement michaelclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RachalCassity RachalCassity self-assigned this May 2, 2024
@balexandr balexandr merged commit eb997d8 into master May 3, 2024
19 checks passed
@balexandr balexandr deleted the 80367-add-prefill-10-7959f-1 branch May 3, 2024 13:59
gabezurita added a commit that referenced this pull request May 3, 2024
* master:
  Dash/oren/api 34439/local bgs refactor (#16526)
  Bump rubocop-rspec from 2.29.1 to 2.29.2 (#16622)
  Revert "Removed feature toggle profile_show_proof_of_veteran_status (#16368)" (#16617)
  Simple Forms: Pull pdf upload out into a service (#16615)
  80367 add prefill 10 7959f 1 (#16499)
  arf-80297 add ARP verified_representative migration (#16494)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants