Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE | Ask Va Api: Update Inquiries::Retriever and Correspondences::Retriever #16512

Merged
merged 1 commit into from
Apr 26, 2024
Merged

BE | Ask Va Api: Update Inquiries::Retriever and Correspondences::Retriever #16512

merged 1 commit into from
Apr 26, 2024

Conversation

Khoa-V-Nguyen
Copy link
Contributor

Summary

  • Updated Inquiries::Retriever and Correspondences::Retriever

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@Khoa-V-Nguyen Khoa-V-Nguyen self-assigned this Apr 25, 2024
@Khoa-V-Nguyen Khoa-V-Nguyen requested review from a team as code owners April 25, 2024 23:48
@Khoa-V-Nguyen Khoa-V-Nguyen enabled auto-merge (squash) April 25, 2024 23:49
@va-vfs-bot va-vfs-bot temporarily deployed to ask-va-api-inquiries-fetch-by-id/main/main April 25, 2024 23:52 Inactive
joehall-tw
joehall-tw approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@joehall-tw joehall-tw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had some questions, but Khoa caught me up.

@Khoa-V-Nguyen Khoa-V-Nguyen force-pushed the ask-va-api-inquiries-fetch-by-id branch from 4a8572c to 6f2022d Compare April 26, 2024 00:00
@Khoa-V-Nguyen Khoa-V-Nguyen merged commit e76f788 into master Apr 26, 2024
20 checks passed
@Khoa-V-Nguyen Khoa-V-Nguyen deleted the ask-va-api-inquiries-fetch-by-id branch April 26, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehall-tw joehall-tw joehall-tw approved these changes

Assignees

@Khoa-V-Nguyen Khoa-V-Nguyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Khoa-V-Nguyen @joehall-tw @va-vfs-bot