-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DBEX] create Lighthouse526DocumentUpload migration #17405
[DBEX] create Lighthouse526DocumentUpload migration #17405
Conversation
@freeheeling a bad test was introduced into master. Could you update your branch to resolve the failing code check? |
@stevenjcumming Merged master branch in. All checks now passing. Please review. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line to the end of your migration file
@stevenjcumming – Addressed in a64e9bb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me assuming you're good with the schema I came up with, I felt it may have been a little over-engineered but more data is better than less data and we can always drop columns that don't make sense when you roll out the rest of it
Summary
Objective: Implements a system for periodically polling the Lighthouse uploads/status endpoint to confirm the status of supplemental documents submitted to Lighthouse as part of a Form 526 Submission. The purpose of this system is to surface successes and failures that happen in the Form 526 process after being forwarded to Lighthouse for processing.
Lighthouse526DocumentUpload
database migrationFormAttachment
record, where an S3 pointer for the document is storedrequestId
returned by Lighthouse, aslighthouse_document_request_id
YES/NORelated issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria