Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBEX] create Lighthouse526DocumentUpload migration #17405

Merged

Conversation

freeheeling
Copy link
Contributor

Summary

Objective: Implements a system for periodically polling the Lighthouse uploads/status endpoint to confirm the status of supplemental documents submitted to Lighthouse as part of a Form 526 Submission. The purpose of this system is to surface successes and failures that happen in the Form 526 process after being forwarded to Lighthouse for processing.

  • Create Lighthouse526DocumentUpload database migration
    • model that represents a document uploaded to Lighthouse
    • Veteran Upload document types have an associated FormAttachment record, where an S3 pointer for the document is stored
    • will store the requestId returned by Lighthouse, as lighthouse_document_request_id
  • Subsequent PRs will implement model validations and methods, as well as interaction with the Lighthouse Benefits Document API client
  • This work is behind a feature toggle (flipper): YES/NO
  • Responsible team: Disability Benefits Experience Team 2 (dBeX Carbs 🥖)

Related issue(s)

Testing done

  • Database migration; nothing to test

What areas of the site does it impact?

  • non-user facing, asynchronous job tracking the status of uploaded documents submitted in conjunction with Form 526EZ

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@freeheeling freeheeling added disability-experience To manage benefits disability claims experience. disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) labels Jul 3, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to dbex/87617-create-lighthouse526-document-uploads/main/main July 3, 2024 20:59 Inactive
tblackwe
tblackwe previously approved these changes Jul 3, 2024
@freeheeling freeheeling marked this pull request as ready for review July 3, 2024 22:38
@freeheeling freeheeling requested review from a team as code owners July 3, 2024 22:38
@stevenjcumming
Copy link
Contributor

@freeheeling a bad test was introduced into master. Could you update your branch to resolve the failing code check?

@va-vfs-bot va-vfs-bot temporarily deployed to dbex/87617-create-lighthouse526-document-uploads/main/main July 6, 2024 11:57 Inactive
@freeheeling
Copy link
Contributor Author

@freeheeling a bad test was introduced into master. Could you update your branch to resolve the failing code check?

@stevenjcumming Merged master branch in. All checks now passing. Please review. Thank you!

Copy link
Contributor

@stevenjcumming stevenjcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line to the end of your migration file

@freeheeling
Copy link
Contributor Author

freeheeling commented Jul 8, 2024

Please add a new line to the end of your migration file

@stevenjcumming – Addressed in a64e9bb

Copy link
Contributor

@NB28VT NB28VT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me assuming you're good with the schema I came up with, I felt it may have been a little over-engineered but more data is better than less data and we can always drop columns that don't make sense when you roll out the rest of it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants