Api 41369 remove v1 base method bgs ext

config/features.yml

@@ -245,6 +245,10 @@ features:
     actor_type: user
     description: When enabled, sends poa forms to BD via the refactored logic
     enable_in_development: true
+  claims_api_526_validations_v1_local_bgs:
+    actor_type: user
+    description: Enables the method calls in the v1 526 validations use local_bgs
+    enable_in_development: true
   claims_api_use_person_web_service:
     actor_type: user
     description: Uses person web service rather than local bgs

modules/claims_api/app/clients/claims_api/bgs_client/definitions.rb

@@ -203,6 +203,20 @@ module FindPersonBySSN
         end
       end
 
+      ##
+      # StandardDataService
+      #
+      module StandardDataService
+        DEFINITION =
+          Bean.new(
+            path: 'StandardDataService',
+            namespaces: Namespaces.new(
+              target: 'http://services.mapd.benefits.vba.va.gov/',
+              data: nil
+            )
+          )
+      end
+
       ##
       # StandardDataWebServiceBean
       #

modules/claims_api/app/controllers/concerns/claims_api/disability_compensation_validations.rb

@@ -2,6 +2,7 @@
 
 require 'common/exceptions'
 require 'brd/brd'
+require 'bgs_service/standard_data_service'
 
 module ClaimsApi
   module DisabilityCompensationValidations # rubocop:disable Metrics/ModuleLength
@@ -424,7 +425,15 @@ def validate_form_526_disability_classification_code!
     def bgs_classification_ids
       return @bgs_classification_ids if @bgs_classification_ids.present?
 
-      contention_classification_type_codes = bgs_service.data.get_contention_classification_type_code_list
+      contention_classification_type_codes = if Flipper.enabled?(:claims_api_526_validations_v1_local_bgs)
+                                               contention_service = ClaimsApi::StandardDataService.new(
+                                                 external_uid: Settings.bgs.external_uid,
+                                                 external_key: Settings.bgs.external_key
+                                               )
+                                               contention_service.get_contention_classification_type_code_list
+                                             else
+                                               bgs_service.data.get_contention_classification_type_code_list
+                                             end
       @bgs_classification_ids = contention_classification_type_codes.pluck(:clsfcn_id)
     end
 

modules/claims_api/lib/bgs_service/standard_data_service.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module ClaimsApi
+  class StandardDataService < ClaimsApi::LocalBGS
+    def bean_name
+      'StandardDataService'
+    end
+
+    def get_contention_classification_type_code_list
+      body = Nokogiri::XML::DocumentFragment.parse <<~EOXML
+        <getContentionClassificationTypeCodeList/>
+      EOXML
+
+      response = make_request(endpoint: bean_name, action: 'getContentionClassificationTypeCodeList', body:)
+      response[:return]
+    end
+  end
+end

modules/claims_api/spec/requests/v1/forms/526_spec.rb

@@ -2,6 +2,7 @@
 
 require 'rails_helper'
 require_relative '../../../rails_helper'
+require 'bgs_service/standard_data_service'
 
 RSpec.describe 'ClaimsApi::V1::Forms::526', type: :request do
   let(:headers) do
@@ -2274,34 +2275,45 @@ def obj.class
       context "when 'disabilites.secondaryDisabilities.classificationCode' is invalid" do
         let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }
 
-        before do
-          expect_any_instance_of(BGS::StandardDataService)
-            .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
-        end
+        [true, false].each do |flipped|
+          context "when feature flag is #{flipped}" do
+            before do
+              if flipped
+                Flipper.enable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(ClaimsApi::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              else
+                Flipper.disable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(BGS::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              end
+            end
 
-        it 'raises an exception' do
-          mock_acg(scopes) do |auth_header|
-            VCR.use_cassette('claims_api/brd/countries') do
-              json_data = JSON.parse data
-              params = json_data
-              disabilities = [
-                {
-                  disabilityActionType: 'NONE',
-                  name: 'PTSD (post traumatic stress disorder)',
-                  diagnosticCode: 9999,
-                  secondaryDisabilities: [
+            it 'raises an exception' do
+              mock_acg(scopes) do |auth_header|
+                VCR.use_cassette('claims_api/brd/countries') do
+                  json_data = JSON.parse data
+                  params = json_data
+                  disabilities = [
                     {
-                      disabilityActionType: 'SECONDARY',
-                      name: 'PTSD',
-                      serviceRelevance: 'Caused by a service-connected disability.',
-                      classificationCode: '2222'
+                      disabilityActionType: 'NONE',
+                      name: 'PTSD (post traumatic stress disorder)',
+                      diagnosticCode: 9999,
+                      secondaryDisabilities: [
+                        {
+                          disabilityActionType: 'SECONDARY',
+                          name: 'PTSD',
+                          serviceRelevance: 'Caused by a service-connected disability.',
+                          classificationCode: '2222'
+                        }
+                      ]
                     }
                   ]
-                }
-              ]
-              params['data']['attributes']['disabilities'] = disabilities
-              post path, params: params.to_json, headers: headers.merge(auth_header)
-              expect(response).to have_http_status(:bad_request)
+                  params['data']['attributes']['disabilities'] = disabilities
+                  post path, params: params.to_json, headers: headers.merge(auth_header)
+                  expect(response).to have_http_status(:bad_request)
+                end
+              end
             end
           end
         end
@@ -2310,34 +2322,45 @@ def obj.class
       context "when 'disabilites.secondaryDisabilities.classificationCode' does not match name" do
         let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }
 
-        before do
-          expect_any_instance_of(BGS::StandardDataService)
-            .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
-        end
+        [true, false].each do |flipped|
+          context "when feature flag is #{flipped}" do
+            before do
+              if flipped
+                Flipper.enable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(ClaimsApi::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              else
+                Flipper.disable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(BGS::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              end
+            end
 
-        it 'raises an exception' do
-          mock_acg(scopes) do |auth_header|
-            VCR.use_cassette('claims_api/brd/countries') do
-              json_data = JSON.parse data
-              params = json_data
-              disabilities = [
-                {
-                  disabilityActionType: 'NONE',
-                  name: 'PTSD (post traumatic stress disorder)',
-                  diagnosticCode: 9999,
-                  secondaryDisabilities: [
+            it 'raises an exception' do
+              mock_acg(scopes) do |auth_header|
+                VCR.use_cassette('claims_api/brd/countries') do
+                  json_data = JSON.parse data
+                  params = json_data
+                  disabilities = [
                     {
-                      disabilityActionType: 'SECONDARY',
-                      name: 'PTSD',
-                      serviceRelevance: 'Caused by a service-connected disability.',
-                      classificationCode: '1111'
+                      disabilityActionType: 'NONE',
+                      name: 'PTSD (post traumatic stress disorder)',
+                      diagnosticCode: 9999,
+                      secondaryDisabilities: [
+                        {
+                          disabilityActionType: 'SECONDARY',
+                          name: 'PTSD',
+                          serviceRelevance: 'Caused by a service-connected disability.',
+                          classificationCode: '1111'
+                        }
+                      ]
                     }
                   ]
-                }
-              ]
-              params['data']['attributes']['disabilities'] = disabilities
-              post path, params: params.to_json, headers: headers.merge(auth_header)
-              expect(response).to have_http_status(:bad_request)
+                  params['data']['attributes']['disabilities'] = disabilities
+                  post path, params: params.to_json, headers: headers.merge(auth_header)
+                  expect(response).to have_http_status(:bad_request)
+                end
+              end
             end
           end
         end
@@ -2458,52 +2481,65 @@ def obj.class
 
     describe "'disabilites' validations" do
       describe "'disabilities.classificationCode' validations" do
-        let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }
+        [true, false].each do |flipped|
+          context "when feature flag is #{flipped}" do
+            before do
+              if flipped
+                Flipper.enable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(ClaimsApi::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              else
+                Flipper.disable(:claims_api_526_validations_v1_local_bgs)
+                expect_any_instance_of(BGS::StandardDataService)
+                  .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
+              end
+            end
 
-        before do
-          expect_any_instance_of(BGS::StandardDataService)
-            .to receive(:get_contention_classification_type_code_list).and_return(classification_type_codes)
-        end
+            let(:classification_type_codes) { [{ clsfcn_id: '1111' }] }
 
-        context "when 'disabilites.classificationCode' is valid" do
-          it 'returns a successful response' do
-            mock_acg(scopes) do |auth_header|
-              VCR.use_cassette('claims_api/bgs/claims/claims') do
-                VCR.use_cassette('claims_api/brd/countries') do
-                  json_data = JSON.parse data
-                  params = json_data
-                  disabilities = [
-                    {
-                      disabilityActionType: 'NEW',
-                      name: 'PTSD (post traumatic stress disorder)',
-                      classificationCode: '1111'
-                    }
-                  ]
-                  params['data']['attributes']['disabilities'] = disabilities
-                  post path, params: params.to_json, headers: headers.merge(auth_header)
-                  expect(response).to have_http_status(:ok)
+            context "when 'disabilites.classificationCode' is valid" do
+              it 'returns a successful response' do
+                mock_acg(scopes) do |auth_header|
+                  VCR.use_cassette('claims_api/bgs/claims/claims') do
+                    VCR.use_cassette('claims_api/brd/countries') do
+                      json_data = JSON.parse data
+                      params = json_data
+                      disabilities = [
+                        {
+                          disabilityActionType: 'NEW',
+                          name: 'PTSD (post traumatic stress disorder)',
+                          classificationCode: '1111'
+                        }
+                      ]
+                      params['data']['attributes']['disabilities'] = disabilities
+                      post path, params: params.to_json, headers: headers.merge(auth_header)
+                      expect(response).to have_http_status(:ok)
+                    end
+                  end
                 end
               end
             end
-          end
-        end
 
-        context "when 'disabilites.classificationCode' is invalid" do
-          it 'responds with a bad request' do
-            mock_acg(scopes) do |auth_header|
-              VCR.use_cassette('claims_api/brd/countries') do
-                json_data = JSON.parse data
-                params = json_data
-                disabilities = [
-                  {
-                    disabilityActionType: 'NEW',
-                    name: 'PTSD (post traumatic stress disorder)',
-                    classificationCode: '2222'
-                  }
-                ]
-                params['data']['attributes']['disabilities'] = disabilities
-                post path, params: params.to_json, headers: headers.merge(auth_header)
-                expect(response).to have_http_status(:bad_request)
+            context "when 'disabilites.classificationCode' is invalid" do
+              it 'responds with a bad request' do
+                mock_acg(scopes) do |auth_header|
+                  VCR.use_cassette('claims_api/brd/countries') do
+                    VCR.use_cassette('claims_api/bgs/stadard_service_data') do
+                      json_data = JSON.parse data
+                      params = json_data
+                      disabilities = [
+                        {
+                          disabilityActionType: 'NEW',
+                          name: 'PTSD (post traumatic stress disorder)',
+                          classificationCode: '2222'
+                        }
+                      ]
+                      params['data']['attributes']['disabilities'] = disabilities
+                      post path, params: params.to_json, headers: headers.merge(auth_header)
+                      expect(response).to have_http_status(:bad_request)
+                    end
+                  end
+                end
               end
             end
           end