Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] Use json_schemer in SavedClaim #19684

Merged
merged 44 commits into from
Dec 18, 2024
Merged

Conversation

iandonovan
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES
  • We are looking at resolving an issue with JSON Schema. Our idea is to use the json_schemer gem instead, and we are using the SavedClaim model as its first touchpoint.
  • I am on BMT-2.

Related issue(s)

Testing done

  • New code is covered by unit tests

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 3, 2024 17:33 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 3, 2024 19:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 4, 2024 16:24 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 4, 2024 17:22 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 4, 2024 18:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 4, 2024 19:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 4, 2024 21:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 9, 2024 17:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 17, 2024 15:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to 98065/replace-json-schema/main/main December 17, 2024 16:10 Inactive
Copy link
Contributor

@mjknight50 mjknight50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@iandonovan
Copy link
Contributor Author

@mjknight50 @ericboehs Thank you for reviewing!

I see the Danger action here telling me to split this PR up. I don't think this PR is a good candidate for that; unless I'm missing something fundamental, this PR is a small code change and a lot of testing changes, so splitting it would result in a smaller PR that fails tests 😂

I'm not seeing documentation about the process for getting an exception to that rule. Do you know how I can go about that?

@ericboehs ericboehs merged commit 8a998c8 into master Dec 18, 2024
108 of 110 checks passed
@ericboehs ericboehs deleted the 98065/replace-json-schema branch December 18, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants