-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CST] Use json_schemer in SavedClaim #19684
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GTG
@mjknight50 @ericboehs Thank you for reviewing! I see the Danger action here telling me to split this PR up. I don't think this PR is a good candidate for that; unless I'm missing something fundamental, this PR is a small code change and a lot of testing changes, so splitting it would result in a smaller PR that fails tests 😂 I'm not seeing documentation about the process for getting an exception to that rule. Do you know how I can go about that? |
Summary
json_schemer
gem instead, and we are using theSavedClaim
model as its first touchpoint.Related issue(s)
Testing done
Acceptance criteria