Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rails 7.2.2 -> 8.0.0 #19853

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Update rails 7.2.2 -> 8.0.0 #19853

wants to merge 16 commits into from

Conversation

ryan-mcneil
Copy link
Contributor

WIP

Summary

  • Update Rails 7.2.2 -> 8.0.0

Related issue(s)

Testing done

  • New code is covered by unit tests

@ryan-mcneil ryan-mcneil requested a review from a team as a code owner December 12, 2024 00:39
@ryan-mcneil ryan-mcneil requested review from a team as code owners December 12, 2024 04:04
ryan-mcneil
ryan-mcneil commented Dec 12, 2024
View reviewed changes
modules/vba_documents/spec/models/upload_file_spec.rb
@@ -21,6 +21,6 @@
it 'does not instantiatiate on UploadSubmission' do
upload_model = VBADocuments::UploadSubmission.new
upload_model.save!
expect { VBADocuments::UploadFile.find_by(guid: upload_model.guid) }.to raise_error(ActiveRecord::StatementInvalid)
expect { VBADocuments::UploadFile.find_by(guid: upload_model.guid) }.to raise_error(TypeError)
Copy link
Contributor Author

@ryan-mcneil ryan-mcneil Dec 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot find the exact change, but in previous versions it seems that errors raised during activerecord execution were raised as ActiveRecord::StatementInvalid. Now it seems that it raises the error explicitly raised in the code

@ryan-mcneil ryan-mcneil requested a review from a team as a code owner December 17, 2024 00:15
@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 00:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 01:09 Inactive
@ericboehs ericboehs marked this pull request as draft December 17, 2024 19:51
@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 22:52 Inactive
@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 23:29 Inactive
@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 23:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to rm-update-rails-8.0/main/main December 17, 2024 23:49 Inactive
@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

@github-actions GitHub Actions
Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: config/initializers/new_framework_defaults_7_0.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codeowners-addition-failure lint-failure require-backend-approval test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-mcneil @va-vfs-bot