-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
99019: Add deprecation warning and unschedule DR non-engine jobs #19941
Open
dfong-adh
wants to merge
2
commits into
master
Choose a base branch
from
99019-dr-logging-for-old-job-usage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfong-adh
changed the title
99019: Add deprecation warning for DR non-engine jobs and remove from periodic jobs
99019: Add deprecation warning and remove DR non-engine jobs from scheduler
Dec 18, 2024
dfong-adh
changed the title
99019: Add deprecation warning and remove DR non-engine jobs from scheduler
99019: Add deprecation warning and unschedule DR non-engine jobs
Dec 18, 2024
…emove from periodic jobs
dfong-adh
force-pushed
the
99019-dr-logging-for-old-job-usage
branch
from
December 18, 2024 00:23
2809d00
to
3a3eed5
Compare
va-vfs-bot
temporarily deployed
to
99019-dr-logging-for-old-job-usage/main/main
December 18, 2024 00:33
Inactive
shaunburdick
previously approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.deprecated
ericboehs
requested changes
Dec 18, 2024
dfong-adh
force-pushed
the
99019-dr-logging-for-old-job-usage
branch
from
December 19, 2024 22:15
ab2a3a8
to
54d02c2
Compare
shaunburdick
approved these changes
Dec 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds a deprecation warning to old jobs that are being replaced by Decision Review engine versions of the same jobs. This also removes the jobs from the periodic jobs list so they are no longer run automatically.
This is owned by the Benefits Decision Review team.
Related issue(s)
department-of-veterans-affairs/va.gov-team#99019
Testing done
Tested locally
What areas of the site does it impact?
This impacts the scheduled jobs.
Acceptance criteria