Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

99019: Add deprecation warning and unschedule DR non-engine jobs #19941

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dfong-adh
Copy link
Contributor

@dfong-adh dfong-adh commented Dec 18, 2024

Summary

This adds a deprecation warning to old jobs that are being replaced by Decision Review engine versions of the same jobs. This also removes the jobs from the periodic jobs list so they are no longer run automatically.

This is owned by the Benefits Decision Review team.

Related issue(s)

department-of-veterans-affairs/va.gov-team#99019

Testing done

Tested locally

What areas of the site does it impact?

This impacts the scheduled jobs.

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

@dfong-adh dfong-adh changed the title 99019: Add deprecation warning for DR non-engine jobs and remove from periodic jobs 99019: Add deprecation warning and remove DR non-engine jobs from scheduler Dec 18, 2024
@dfong-adh dfong-adh changed the title 99019: Add deprecation warning and remove DR non-engine jobs from scheduler 99019: Add deprecation warning and unschedule DR non-engine jobs Dec 18, 2024
@dfong-adh dfong-adh force-pushed the 99019-dr-logging-for-old-job-usage branch from 2809d00 to 3a3eed5 Compare December 18, 2024 00:23
@va-vfs-bot va-vfs-bot temporarily deployed to 99019-dr-logging-for-old-job-usage/main/main December 18, 2024 00:33 Inactive
shaunburdick
shaunburdick previously approved these changes Dec 18, 2024
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.deprecated

@dfong-adh dfong-adh marked this pull request as ready for review December 18, 2024 17:06
@dfong-adh dfong-adh requested review from a team as code owners December 18, 2024 17:06
@dfong-adh dfong-adh force-pushed the 99019-dr-logging-for-old-job-usage branch from ab2a3a8 to 54d02c2 Compare December 19, 2024 22:15
Copy link
Contributor

@shaunburdick shaunburdick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants