Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update holidays gem #3634

Merged
merged 3 commits into from
Dec 13, 2019
Merged

update holidays gem #3634

merged 3 commits into from
Dec 13, 2019

Conversation

annaswims
Copy link
Contributor

@annaswims annaswims commented Dec 12, 2019 •
edited
Loading

Description of change

we use the holiday gem to skip the job creating education spool files on federal holidays.

I read the changelog and verified that we have appropriate test coverage

Testing done

specs

@annaswims
Copy link
Contributor Author

Changelog

8.0.0

  • Remove support for ruby 2.2 and ruby 2.3.
  • Add support for latest ruby 2.6
  • Update to v5.0.1 definitions. Please see the changelog for the definition details.

7.1.0

7.0.0

Major semver bump due to the major version change in the definitions. Several non ISO regions have been modified in order to provide more clarity for parent and sub-regions.

Affected regions:

  • ecb_target region changed to ecbtarget
  • federal_reserve region changed to federalreserve
  • federalreservebanks region changed to federalreservebanks
  • north_america_informal region changed to northamericainformal
  • united_nations region changed to unitednations
  • north_america region changed to northamerica
  • south_america region changed to southamerica

Please see the definitions v4.0.0 CHANGELOG for the full change list.

6.6.1

  • Fixes any_holidays_during_work_week? so that it actually does what it says it does issue-264

6.6.0

  • Update to v3.0.0 definitions. This required updates to the custom method parser but no behavior changes.
  • Remove unused simplecov-rcov from gemspec dev dependencies
  • Fix parent region loading bug PR (thanks to chadrschroeder)
  • Fix ruby-head build caused by new 'endless range' feature in ruby 2.6.0 PR
  • Refactor definition search logic for improved readability PR (thanks to https://github.com/guizma)
  • Reorganize most documentation into the docs/ directory
  • Fix list of covered rubies in README

6.5.0

  • Update to v2.5.2 definitions. Please see the changelog for the definition details.
  • Fix permissions on bin executables (thanks to github.com/JuanitoFatas)

6.4.0

6.3.0

6.2.0

6.1.0

6.0.0

  • Remove support for ruby 2.1.0 since it is no longer officially supported. This is the cause of the major
    version bump.
  • Update to v2.0.0 definitions. This changes the format
    of definition tests and requires the other changes.
  • Rewrite test generation logic to consume new YAML format.

To be crystal clear: this version should not behave differently in terms of holiday results than v5.7.0 of the gem. Any
differences are a bug that should be addressed.

5.7.0

  • Update to v1.7.1 definitions. Please see the
    definitions repository for the list of changes.
  • Remove 'coveralls'. We never looked at the reports. We will we simplecov to enforce test coverage. It will
    start off being set to require 99% and above.

5.6.0

  • Update to v1.6.1 definitions, which includes updates for the :ca region (and subregions)

5.5.1

  • Update to v1.5.1 definitions, which includes bugfix in fedex custom method

5.5.0

  • Fix #251: load_custom would override all other definitions
  • Fix #266: :any does not return expected results
  • Fix #265: Jersey/je not loaded as expected when pulling :gb
  • Add lunar date calculations, which are used in :kr and :vi definitions (thanks to https://github.com/jonathanpike)
  • Improve cache performance (thanks to https://github.com/mzruya)
  • Remove incorrect comments in definition generation (thanks to https://github.com/morrme)
  • Fix bug related to definition functions inadvertently affecting subsequent date calculations
  • Point to latest version (1.5.0) of definitions, which includes:
    • Add Vietnamese holidays
    • Updates Australian holidays
    • Updates Korean holidays to use native language and fancy lunar date calculations
    • Fix NYSE definitions to correctly calculate observed "New Year's Day"

@annaswims
Copy link
Contributor Author

Holiday definition changelog:

Holiday definitions

5.0.1

No behavior change.

Commenting out a failing it test due to limitations of the current definition format. Unfortunately a holiday was added to the it region that falls on the same day as another existing region and we do not alwayd handle that in a uniform, consistent way. Currently there is no way to test that the second region that is returned on a day is valid. Because of this I'm commenting out the test and moving forward. We'll need to add this functionality later.

I only caught this when releasing the ruby gem. This goes back once again to this issue with how we can test against an actual implementation from this repository.

5.0.0

Major semver bump due to changes related to the year_ranges option. The following keys have been renamed:

  • before is now until
  • after is now from

The behavior of these two options has not changed. To read more about the reasons behind this change please see the associated ADR.

Definitions changes:

4.1.0

4.0.0

Major semver bump due to changes in how non-standard regions will be handled going forward. Please see issue-110 for more details on this edge case and please also see the updates to our SYNTAX guide for the specified behavior going forward.

The following non-standard regions have been changed:

  • ecb_target region changed to ecbtarget
  • federal_reserve region changed to federalreserve
  • federal_reserve_banks region changed to federalreservebanks
  • north_america_informal region changed to northamericainformal
  • united_nations region changed to unitednations
  • north_america region changed to northamerica
  • south_america region changed to southamerica

This change also includes updates to various other regions:

3.1.0

  • Update ch to apply 'Neujahrstag' to overall region (thanks to https://github.com/phylor)
  • Cosmetic spacing update for us definition, no behavior change

3.0.0

Major semver bump as the format for custom methods has been changed to complete issue-24. Downstream consumers will need to update to be able to parse them. However there are no behavior changes with this update.

In summary: we have switched to language-specific custom methods. Instead of a plain source field you will need a specific language implementation, e.g. ruby, golang, etc.

Currently we only have ruby but we can now expand these definitions for use in other languages. Please see the custom methods ADR for more in-depth information on why this change was made.

You can also view the updated 'Methods' section in the SYNTAX doc for more info and examples.

2.5.3

  • Add missing observed logic for 'St. Patricks Day' in gb_nir

2.5.2

  • Fix de issue cause by undefined year_ranges behavior in syntax

2.5.1

  • Fix Federal Reserve Independence Day tests

2.5.0

2.4.0

2.3.0

2.2.1

  • Small updates to tests in the :de regions. No behavior changes.

2.2.0

2.1.1

  • Comment out test for 추석 until a discussion can be had in issue 69 (nice)

2.1.0

Update the following regions:

  • ca_ab - change 'Heritage Day' to informal
  • kr - Update '추석 연휴' and 설날 연휴 for accuracy
  • cl - Add 'San Pedro y San Pablo', update 'Encuentro de Dos Mundos', and add 'Día de las Iglesias Evangélicas y Protestantes'

2.0.0

  • Update tr, fedex for accuracy
  • Completely change the test format to no longer use ruby source code! Hooray! This should cause no behavior differences,
    any differences or changes in behavior should be considered a regression.

1.7.1

A small bugfix that resolves the naming issues of two regions in the 'index.yaml' file. No other outward changes.

1.7.0

Here are the changes:

  • Add Estonian definitions
  • Enhance France definitions
  • Correct and enhance German definitions
  • Enhance Portuguese definitions
  • Add Malta definitions
  • Add Serbian definitions
  • Add Georgian definitions
  • Use Orthodox easter calculations in appropriate regions
  • Add Russian definitions
  • Add Turkey definitions
  • Enhance US definitions (lots of individual US states!)
  • Update South Australian definitions

1.6.1

  • Update ca test for correctness. See below for more information.

Unfortunately due to our current setup it is possible for definitions/tests in this repository to appear 'valid' but only
fail when we run them in the actual ruby holidays repo. This is a known issue (#42) and needs to be addressed.

In the meantime, this is a bugfix release to ensure we can release v5.6.0 of the ruby repo.

1.6.0

Updates to the following Canadian regions: ca_ab, ca_bc, ca_mb, ca_nt, ca_nu, ca_on, ca_sk, ca_yt, ca_pe

1.5.1

  • Fix error in fedex custom method day_after_thanksgiving

@va-vfs-bot va-vfs-bot temporarily deployed to update_holidays_gem/master December 12, 2019 15:10 Inactive
@annaswims annaswims marked this pull request as ready for review December 12, 2019 15:16
@annaswims annaswims requested review from a team as code owners December 12, 2019 15:16
@annaswims annaswims mentioned this pull request Dec 12, 2019
Closed
4 tasks
@va-vfs-bot va-vfs-bot temporarily deployed to update_holidays_gem/master December 12, 2019 15:23 Inactive
jholton
jholton approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@jholton jholton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annaswims annaswims merged commit 2b33147 into master Dec 13, 2019
@annaswims annaswims deleted the update_holidays_gem branch December 13, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholton jholton jholton approved these changes

@johnpaulashenfelter johnpaulashenfelter Awaiting requested review from johnpaulashenfelter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annaswims @jholton @va-vfs-bot