Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vets json schema #914

Merged
merged 3 commits into from
Apr 13, 2017
Merged

Update vets json schema #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cf0879
update vets json schema
lihanli Apr 11, 2017
717796f
add previous benefits va file number to 5490 spool
lihanli Apr 11, 2017
1df3284
Merge branch 'master' into update-vets-json-schema
lihanli Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
GIT
remote: https://github.com/department-of-veterans-affairs/vets-json-schema
revision: 7ef76dfb7e334a23db5b663a8c0dff15747748f6
revision: 69416130cb487d1aa63d58632a1c33ccec4ce134
branch: master
specs:
vets_json_schema (2.1.1)
vets_json_schema (2.2.0)
multi_json (~> 1.0)
script_utils (= 0.0.4)

Expand Down
2 changes: 2 additions & 0 deletions app/workers/education_form/templates/5490.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ Name of individual on whose account previously claimed: <%= full_name(@applicant

SSN of individual on whose account previously claimed: <%= @applicant.previousBenefits&.veteranSocialSecurityNumber %>

VA File Number for previously claimed benefits: <%= @applicant.previousBenefits&.vaFileNumber %>


ACTIVE DUTY SERVICE INFORMATION
-------------------------------
Expand Down
3 changes: 2 additions & 1 deletion spec/fixtures/education_benefits_claims/5490/kitchen_sink.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"first": "Mark",
"last": "Olson"
},
"veteranSocialSecurityNumber": "111223333"
"veteranSocialSecurityNumber": "111223333",
"vaFileNumber": "c12345679"
},
"highSchool": {
"name": "PS1",
Expand Down
2 changes: 2 additions & 0 deletions spec/fixtures/education_benefits_claims/5490/kitchen_sink.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ Name of individual on whose account previously claimed: Mark Olson

SSN of individual on whose account previously claimed: 111223333

VA File Number for previously claimed benefits: c12345679


ACTIVE DUTY SERVICE INFORMATION
-------------------------------
Expand Down
2 changes: 2 additions & 0 deletions spec/fixtures/education_benefits_claims/5490/simple.spl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ Name of individual on whose account previously claimed:

SSN of individual on whose account previously claimed:

VA File Number for previously claimed benefits:


ACTIVE DUTY SERVICE INFORMATION
-------------------------------
Expand Down