Copy vendor entry to shared-modules #12427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvalarida
approved these changes
Apr 29, 2020
| @@ -53,6 +53,7 @@ fi | |||
| if [ "${assetSource}" = "local" ]; then | |||
| echo "Building application assets" | |||
| yarn build:webpack $webpackArgs | |||
| cp -v "${buildDir}generated/vendor.entry.js" "${buildDir}generated/shared-modules.entry.js" | |||
There was a problem hiding this comment.
🤔 This works for now, but we may need to circle back to this later. My tentative goal is to remove this script altogether when we move the content build out. If we still need this by then, we can come up with a better approach.
There was a problem hiding this comment.
Sounds good to me. I'm hoping we won't need this at that point.
bkjohnson
added a commit
that referenced
this pull request
Apr 30, 2020
This reverts commit 4a33708.
This was referenced Apr 30, 2020
Merged
ethanteague
pushed a commit
that referenced
this pull request
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of department-of-veterans-affairs/va.gov-team#8560
I initially tried to accomplish this using our existing webpack config but had no luck. There are some additional plugins discussed here that might work, but it seemed simpler to just use
cpTesting done
Successful local website build
Screenshots
Acceptance criteria
Definition of done