Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove eslint-plugin-no-unsafe-innerhtml #12638

Merged
merged 3 commits into from
May 13, 2020
Merged

Remove eslint-plugin-no-unsafe-innerhtml #12638

merged 3 commits into from
May 13, 2020

Conversation

jhonnyoddball
Copy link
Contributor

@jhonnyoddball jhonnyoddball commented May 12, 2020 •
edited
Loading

Description

This PR will remove eslint-plugin-no-unsafe-innerhtml

Testing done

Locally

Acceptance criteria

  • No errors caused

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@jhonnyoddball jhonnyoddball requested review from bkjohnson and a team May 12, 2020 18:30
@va-bot va-bot temporarily deployed to vetsgov-pr-12638 May 12, 2020 18:30 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/upgrade-eslint-plugin-no-unsafe-innerhtml May 12, 2020 18:59 Inactive
bkjohnson
bkjohnson reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@bkjohnson bkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage docs for this plugin say that it is used by including the no-unsanitized plugin which we aren't doing, so do we need this anymore?

@jhonnyoddball
Copy link
Contributor Author

Based on my initial audit, it's not being used. I guess we should remove it. I think this is the best time to do it

@va-bot va-bot temporarily deployed to vetsgov-pr-12638 May 12, 2020 19:38 Inactive
@jhonnyoddball
Copy link
Contributor Author

@bkjohnson It's been updated to remove the plugin

@jhonnyoddball jhonnyoddball changed the title Upgrade eslint-plugin-no-unsafe-innerhtml Remove eslint-plugin-no-unsafe-innerhtml May 12, 2020
@va-vfs-bot va-vfs-bot temporarily deployed to master/upgrade-eslint-plugin-no-unsafe-innerhtml May 12, 2020 20:00 Inactive
@va-bot va-bot temporarily deployed to vetsgov-pr-12638 May 12, 2020 21:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/upgrade-eslint-plugin-no-unsafe-innerhtml May 12, 2020 22:12 Inactive
@jhonnyoddball jhonnyoddball merged commit 89d5683 into master May 13, 2020
@jhonnyoddball jhonnyoddball deleted the upgrade-eslint-plugin-no-unsafe-innerhtml branch May 13, 2020 13:28
@jhonnyoddball jhonnyoddball mentioned this pull request May 13, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkjohnson bkjohnson bkjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhonnyoddball @bkjohnson @va-bot @va-vfs-bot