Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint-plugin-react #12686

Merged
merged 5 commits into from
May 18, 2020
Merged

Upgrade eslint-plugin-react #12686

merged 5 commits into from
May 18, 2020

Conversation

jhonnyoddball
Copy link
Contributor

Description

This PR will upgrade eslint-plugin-react to the latest version

Testing done

Locally

Acceptance criteria

  • No errors caused

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@jhonnyoddball jhonnyoddball requested review from bkjohnson and a team May 15, 2020 16:25
@va-bot va-bot temporarily deployed to vetsgov-pr-12686 May 15, 2020 16:26 Inactive
@@ -67,6 +67,9 @@
"react/no-deprecated": 2,
"react/no-direct-mutation-state": 2,

/* TODO | DISABLED TEMPORARILY */
"react/sort-comp": 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this is fine, from the docs:

This rule is a formatting preference and not following it won't negatively affect the quality of your code. If components organisation isn't a part of your coding standards, then you can leave this rule off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule will become active in the airbnb plugin once we upgrade all related dependencies. It's been disabled temporarily in the meantime.

@va-bot va-bot temporarily deployed to vetsgov-pr-12686 May 18, 2020 17:27 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/upgrade-eslint-plugin-react May 18, 2020 17:56 Inactive
@jhonnyoddball jhonnyoddball merged commit dbeaac2 into master May 18, 2020
@jhonnyoddball jhonnyoddball deleted the upgrade-eslint-plugin-react branch May 18, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants