Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heading elements on 686c-674 and 28-1900 introduction pages #25896

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

zack
Copy link
Contributor

@zack zack commented Sep 27, 2023

department-of-veterans-affairs/va.gov-team#64130

Summary

  • Some headers were using the wrong headings in the form introduction pages, breaking accessibility guidelines.
  • This fix changes some <h4>s to <h3>s to bring us back into compliance.

Related issue(s)

Testing done

  • Checked the new headers using HeadingsMap

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
686c-674 dependents-headers-before deps-headers-after
28-1900 veteran-readiness-headers-before veteran-readiness-headers-after

What areas of the site does it impact?

Just these two forms

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@zack zack changed the title Fix header elements on 686c-674 and 28-1900 introduction pages Fix heading elements on 686c-674 and 28-1900 introduction pages Sep 27, 2023
Copy link
Contributor

@Midge-dev Midge-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤙

@va-vfs-bot va-vfs-bot temporarily deployed to master/dbex-64130-headers/main September 27, 2023 20:45 Inactive
@zack zack marked this pull request as ready for review September 28, 2023 11:55
@zack zack requested a review from a team as a code owner September 28, 2023 11:55
@zack zack requested a review from a team September 28, 2023 11:55
@zack zack requested review from a team as code owners September 28, 2023 11:55
@zack
Copy link
Contributor Author

zack commented Sep 28, 2023

@department-of-veterans-affairs/benefits-team-1-frontend
@department-of-veterans-affairs/vsa-authd-exp-frontend
@department-of-veterans-affairs/dbex-trex

Is anyone available to give this a review? Thanks :)

Copy link
Contributor

@Mottie Mottie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants