Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set an error exit code when the Updater exits with an error #214

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Dec 22, 2023

When running dependabot update, it should exit with a non-zero exit code if the Updater command also exited with a non-zero exit code.

dependabot test will not as the test could be testing error cases and will only fail if the expectations aren't met (or there's a problem running the test).

@jakecoffman jakecoffman requested a review from a team as a code owner December 22, 2023 16:12
Base automatically changed from jakecoffman/final-test-tweaks to main December 22, 2023 16:16
@jakecoffman jakecoffman marked this pull request as draft December 22, 2023 16:31
@jakecoffman jakecoffman force-pushed the jakecoffman/return-updater-error-code branch from 926303e to 207b71c Compare December 22, 2023 16:32
@jakecoffman jakecoffman changed the title return Updater error codes return Updater error codes when running an update Jan 3, 2024
@jakecoffman jakecoffman changed the title return Updater error codes when running an update set an error exit code when the Updater exits with an error Jan 3, 2024
@jakecoffman jakecoffman marked this pull request as ready for review January 3, 2024 17:27
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me to replicate updater behavior as much as possible!

@jakecoffman jakecoffman added this pull request to the merge queue Jan 5, 2024
Merged via the queue into main with commit 9cf9fa8 Jan 5, 2024
69 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/return-updater-error-code branch January 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants