Rename #id_hash to #to_h

Co-authored-by: Barry Gordon <896971+brrygrdn@users.noreply.github.com>
dependabot · Apr 25, 2023 · 5529ce8 · 5529ce8
1 parent 492c9c3
commit 5529ce8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/common/lib/dependabot/dependency_group.rb b/common/lib/dependabot/dependency_group.rb
@@ -4,25 +4,24 @@
 
 module Dependabot
   class DependencyGroup
-    attr_reader :name, :rules, :dependencies, :id
+    attr_reader :name, :rules, :dependencies
 
     def initialize(name:, rules:)
       @name = name
       @rules = rules
       @dependencies = []
-      @id = id_hash
     end
 
     def contains?(dependency)
       @dependencies.include?(dependency) if @dependencies.any?
       rules.any? { |rule| WildcardMatcher.match?(rule, dependency.name) }
     end
 
-    private
-
-    def id_hash
+    def to_h
       { "name" => serialized_group_name }
     end
+
+    private
 
     def serialized_group_name
       name.downcase.gsub("-", "_").to_sym

diff --git a/updater/lib/dependabot/api_client.rb b/updater/lib/dependabot/api_client.rb
@@ -172,7 +172,7 @@ def dependency_group_hash(dependency_change)
       # FIXME: We currently assumpt that _an attempt_ to send a DependencyGroup#id should
       # result in the `grouped-update` flag being set, regardless of whether the
       # DependencyGroup actually exists.
-      { "dependency-group": dependency_change.dependency_group.id }.compact
+      { "dependency-group": dependency_change.dependency_group.to_h }.compact
     end
 
     def create_pull_request_data(dependency_change, base_commit_sha)