Pass exception message directly to peer dependency error handler (#7178)

dependabot · Apr 26, 2023 · 92fcfeb · 92fcfeb
1 parent fb4cf4a
commit 92fcfeb
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb b/npm_and_yarn/lib/dependabot/npm_and_yarn/update_checker/version_resolver.rb
@@ -331,22 +331,22 @@ def fetch_peer_dependency_errors(version:)
           []
         end
 
-        def handle_peer_dependency_errors(error)
+        def handle_peer_dependency_errors(message)
           errors = []
-          if error.message.match?(NPM6_PEER_DEP_ERROR_REGEX)
-            error.message.scan(NPM6_PEER_DEP_ERROR_REGEX) do
+          if message.match?(NPM6_PEER_DEP_ERROR_REGEX)
+            message.scan(NPM6_PEER_DEP_ERROR_REGEX) do
               errors << Regexp.last_match.named_captures
             end
-          elsif error.message.match?(NPM8_PEER_DEP_ERROR_REGEX)
-            error.message.scan(NPM8_PEER_DEP_ERROR_REGEX) do
+          elsif message.match?(NPM8_PEER_DEP_ERROR_REGEX)
+            message.scan(NPM8_PEER_DEP_ERROR_REGEX) do
               errors << Regexp.last_match.named_captures
             end
-          elsif error.message.match?(YARN_PEER_DEP_ERROR_REGEX)
-            error.message.scan(YARN_PEER_DEP_ERROR_REGEX) do
+          elsif message.match?(YARN_PEER_DEP_ERROR_REGEX)
+            message.scan(YARN_PEER_DEP_ERROR_REGEX) do
               errors << Regexp.last_match.named_captures
             end
-          elsif error.message.match?(YARN_BERRY_PEER_DEP_ERROR_REGEX)
-            error.message.scan(YARN_BERRY_PEER_DEP_ERROR_REGEX) do
+          elsif message.match?(YARN_BERRY_PEER_DEP_ERROR_REGEX)
+            message.scan(YARN_BERRY_PEER_DEP_ERROR_REGEX) do
               errors << Regexp.last_match.named_captures
             end
           else
@@ -495,7 +495,7 @@ def run_checker(path:, version:)
 
           run_npm_checker(path: path, version: version)
         rescue SharedHelpers::HelperSubprocessFailed => e
-          handle_peer_dependency_errors(e)
+          handle_peer_dependency_errors(e.message)
         end
 
         def run_yarn_checker(path:, version:, lockfile:)