fixed missing ! and specs

dependabot · Aug 15, 2024 · c5fd850 · c5fd850
1 parent d934ed5
commit c5fd850
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/common/lib/dependabot/notices.rb b/common/lib/dependabot/notices.rb
@@ -142,7 +142,7 @@ def self.generate_pm_unsupported_notice(package_manager)
       notice_type = "#{package_manager.name}_unsupported_#{mode.downcase}"
       message = "Dependabot no longer supports `#{package_manager.name}` `v#{package_manager.version}`!"
       ## Create an error markdown message
-      markdown = "> [IMPORTANT]\n"
+      markdown = "> [!IMPORTANT]\n"
       ## Add the error message to the message
       markdown += "> #{message}\n\n"
 

diff --git a/common/spec/dependabot/notices_spec.rb b/common/spec/dependabot/notices_spec.rb
@@ -81,8 +81,8 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
       let(:supported_versions) { nil }
       let(:support_later_versions) { false }
 
-      it "returns nil" do
-        expect(generate_supported_versions_message).to be_nil
+      it "returns empty string" do
+        expect(generate_supported_versions_message).to eq("")
       end
     end
 
@@ -91,7 +91,7 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
       let(:support_later_versions) { false }
 
       it "returns nil" do
-        expect(generate_supported_versions_message).to be_nil
+        expect(generate_supported_versions_message).to eq("")
       end
     end
   end
@@ -125,9 +125,9 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
             type: "bundler_deprecated_warn",
             package_manager_name: "bundler",
             message: "Dependabot will stop supporting `bundler` `v1`!\n" \
-                     "Please upgrade to one of the following versions: v2, v3.",
+                     "Please upgrade to one of the following versions: v2, v3.\n",
             markdown: "> [!WARNING]\n> Dependabot will stop supporting `bundler` `v1`!\n\n" \
-                      "> Please upgrade to one of the following versions: v2, v3."
+                      "> Please upgrade to one of the following versions: v2, v3.\n\n"
           })
       end
     end
@@ -143,9 +143,9 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
             type: "bundler_unsupported_error",
             package_manager_name: "bundler",
             message: "Dependabot no longer supports `bundler` `v1`!\n" \
-                     "Please upgrade to one of the following versions: v2, v3.",
+                     "Please upgrade to one of the following versions: v2, v3.\n",
             markdown: "> [!IMPORTANT]\n> Dependabot no longer supports `bundler` `v1`!\n\n" \
-                      "> Please upgrade to one of the following versions: v2, v3."
+                      "> Please upgrade to one of the following versions: v2, v3.\n\n"
           })
       end
     end
@@ -195,9 +195,9 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
           type: "bundler_deprecated_warn",
           package_manager_name: "bundler",
           message: "Dependabot will stop supporting `bundler` `v1`!\n" \
-                   "Please upgrade to one of the following versions: v2, v3.",
+                   "Please upgrade to one of the following versions: v2, v3.\n",
           markdown: "> [!WARNING]\n> Dependabot will stop supporting `bundler` `v1`!\n\n" \
-                    "> Please upgrade to one of the following versions: v2, v3."
+                    "> Please upgrade to one of the following versions: v2, v3.\n\n"
         })
     end
   end
@@ -223,9 +223,9 @@ def initialize(name:, version:, deprecated_versions: [], unsupported_versions: [
           type: "bundler_unsupported_error",
           package_manager_name: "bundler",
           message: "Dependabot no longer supports `bundler` `v1`!\n" \
-                   "Please upgrade to one of the following versions: v2, v3.",
+                   "Please upgrade to one of the following versions: v2, v3.\n",
           markdown: "> [!IMPORTANT]\n> Dependabot no longer supports `bundler` `v1`!\n\n" \
-                    "> Please upgrade to one of the following versions: v2, v3."
+                    "> Please upgrade to one of the following versions: v2, v3.\n\n"
         })
     end
   end