Fix showing bundler v1 deprecation warnings in PR message and logs (#…

…10554)

* fixed bugs related to pr message markdown and logging.

common/lib/dependabot/notices.rb

@@ -190,6 +190,7 @@ def self.markdown_from_description(notice)
         line = line.strip
         markdown += "> #{line}\n"
       end
+      markdown += ">\n\n"
       markdown
     end
 

common/spec/dependabot/pull_request_creator/message_builder_spec.rb

@@ -168,6 +168,14 @@ def commits_details(base:, head:)
     end
   end
 
+  before do
+    allow(Dependabot::Experiments).to receive(:enabled?).with(:add_deprecation_warn_to_pr_message).and_return(true)
+  end
+
+  after do
+    Dependabot::Experiments.reset!
+  end
+
   describe "#pr_name" do
     subject(:pr_name) { builder.pr_name }
 

updater/lib/dependabot/notices_helpers.rb

@@ -37,20 +37,21 @@ def add_deprecation_notice(notices:, package_manager:)
 
     sig { params(notice: Dependabot::Notice).void }
     def log_notice(notice)
+      logger = Dependabot.logger
       # Log each non-empty line of the deprecation notice description
       notice.description.each_line do |line|
         line = line.strip
         next if line.empty?
 
         case notice.mode
         when Dependabot::Notice::NoticeMode::INFO
-          return Dependabot.logger.info(line)
+          logger.info(line)
         when Dependabot::Notice::NoticeMode::WARN
-          Dependabot.logger.warn(line)
+          logger.warn(line)
         when Dependabot::Notice::NoticeMode::ERROR
-          Dependabot.logger.error(line)
+          logger.error(line)
         else
-          Dependabot.logger.info(line)
+          logger.info(line)
         end
       end
     end