Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lerna packages glob pattern seems inaccurate #808

Closed
imhoffd opened this issue Nov 26, 2018 · 2 comments
Closed

Lerna packages glob pattern seems inaccurate #808

imhoffd opened this issue Nov 26, 2018 · 2 comments

Comments

@imhoffd
Copy link

imhoffd commented Nov 26, 2018

Thanks for Lerna support! ❤️

Everything is working great, but I think globbing may be slightly inaccurate.

We use the following config for our lerna packages:

  "packages": [
    "packages/**"
  ],

We have packages within the packages/ folder, but also within subfolders. It is common to have scoped packages in another level, such as packages/my-package and packages/@my-scope/my-package.

lerna ls shows packages correctly according to our glob (packages/**), but the dependabot UI does not when I hover over the ellipsis next to the package.json for the Lerna repository (only the the packages directly in packages/ folder). Additionally, PRs aren't opened for the packages deeper within packages/, so we aren't getting PRs for our scoped packages.

More specifics here: #197 (comment)

@greysteil
Copy link
Contributor

Thanks for this @dwieeb. I'll take a look into it today.

@greysteil
Copy link
Contributor

Just shipped a fix for this and looks like it's working. Dependabot won't fetch deeply nested packages, but it will now consider one level of nesting, which should be enough for pretty much all use cases.

(Since Dependabot doesn't clone your repo going to full nesting could generate a lot of GitHub requests.)

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants