-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lerna support #197
Lerna support #197
Conversation
a50396c
to
dd3c6e4
Compare
36145bf
to
a9e667c
Compare
9b41524
to
91edd2c
Compare
@greysteil Does this build on an underlying grouping mechanism that would be used in https://github.com/dependabot/feedback/issues/5? 😄 |
@dwieeb - sadly not - that's going to be a separate job. This just reads a |
I'm excited for lerna support regardless! 🎉 |
Deployed, and working well in testing. @dwieeb - if you give it a go let me know. If you add Dependabot at the root of a repo with Lerna it will automatically detect all of the |
@greysteil Sorry for taking forever to get back to you. It seems to be working well, although I think globbing may be slightly inaccurate. (let me know if I should create an issue instead) Take a look at the integration in https://github.com/ionic-team/ionic-cli We use the following config for our lerna packages:
But the dependabot language at the root of the repo only lists the packages as if the glob were |
Currently, Dependabot supports monorepos that use Yarn workspaces, and those that add Dependabot manually for each package. This PR is intended to improve monorepo support further by using the information in a
lerna.json
file to automatically update allpackage.json
and lockfile files in a monorepo at once. (I.e., it extends the current behaviour we use for Yarn workspaces to work for repos with alerna.json
file.)TODO:
package.json
filesFileParser
to handle multiple packages at onceUpdateChecker
to handle multiple packages at once (this should just work)FileUpdater
to handle multiple packages at once