Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report missing nuget files #10247

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Jul 18, 2024

During a restore of a project with a packages.config file, a missing targets/project file will fail the restore. I saw instances in the logs of this resulting in unknown_error but in this case we know exactly what the problem is, so we scan the restore log for a well-known message and surface it appropriately.

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Jul 18, 2024
@brettfo brettfo force-pushed the dev/brettfo/nuget-report-missing-files branch 2 times, most recently from 2457d1e to 8d64aa6 Compare July 18, 2024 22:53
@brettfo brettfo force-pushed the dev/brettfo/nuget-report-missing-files branch from 8d64aa6 to 182de4d Compare July 19, 2024 16:51
@brettfo brettfo marked this pull request as ready for review July 19, 2024 16:52
@brettfo brettfo requested a review from a team as a code owner July 19, 2024 16:52
@abdulapopoola abdulapopoola merged commit 7dcd973 into main Jul 19, 2024
107 checks passed
@abdulapopoola abdulapopoola deleted the dev/brettfo/nuget-report-missing-files branch July 19, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants