removing more of dependency_has_directory feature flag

[jakecoffman]

What are you trying to accomplish?

This reverts the addition of add_handled_group_dependencies in #9938 because it's functionally equivalent to the existing add_handled_dependencies.

PR #8963 added support for multi-dir handling of dependencies. The way our update works, and how DependencySnapshot keeps track of the directory can be described with this pseudocode:

for each group {
  for each directory {
    dependency_snapshot.current_directory = directory
    do_the_update(dependency_snapshot)
  }
}
for each ungrouped_dependency {
  for each directory {
    dependency_snapshot.current_directory = directory
    do_the_update(dependency_snapshot)
  }
}

So anytime add_handled_dependencies is called, it uses the @current_directory which was set earlier. It has context of which directory is currently being updated.

add_handled_group_dependencies does the same thing differently by passing in an array of hashes which has the dependency name and the current directory, but it results in the same outcome.

To further illustrate that, I've kept the existing tests and replaced the calls to add_handled_group_dependencies with calls to add_handled_dependencies (and setting the current_directory) which still passes.

Additionally I have renamed handled_group_dependencies to handled_dependencies_all_directories to reflect what it returns.

How will you know you've accomplished your goal?

Again, there should be no functional difference here.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[landongrindheim]

I'm a little unclear on the method name being used for grouped dependencies, but I don't see that as being the core of this change. I do think we'd really benefit from making it clearer, but want to unblock this so you can keep working 😄

[landongrindheim]

🤔 _all_directories reads as being very open to interpretation. I could see this signaling:

• That the dependencies are mapped to all directories (a product-like result)
• That the dependencies are returned agnostic of their directory 👈
• That the dependencies are combined with their directories (and/or all directories)

From context, I suspect it's the one with 👈 next to it.

Are directories important here? If they are, I wonder if there's another signal we could use to make it unambiguous.

[jakecoffman]

Naming is hard!

In #9610 what I was doing was rename all the directory-contextually-aware code to have a _current_directory suffix, would that be clearer? Then we can leave this as handled_dependencies or even all_handled_dependencies?