fixing rebases not finding the existing pull request due to directory #10320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
In #10195 we added
directory
to the payload, which then came back in theexisting-pull-requests
data, which made these methods stop working because they didn't takedirectory
into account.The fix is to include it in the comparison, but we also need to support the older data as well so that check is done second.
In the future we can DRY this up, but for now it works!
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Rebases will start working again.
Checklist