Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing rebases not finding the existing pull request due to directory #10320

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Jul 30, 2024

What are you trying to accomplish?

In #10195 we added directory to the payload, which then came back in the existing-pull-requests data, which made these methods stop working because they didn't take directory into account.

The fix is to include it in the comparison, but we also need to support the older data as well so that check is done second.

In the future we can DRY this up, but for now it works!

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Rebases will start working again.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review July 30, 2024 21:24
@jakecoffman jakecoffman requested a review from a team as a code owner July 30, 2024 21:24
@jakecoffman
Copy link
Member Author

I verified this fixed rebases.

@jakecoffman jakecoffman merged commit c625d6e into main Jul 30, 2024
124 checks passed
@jakecoffman jakecoffman deleted the fix-rebase-again branch July 30, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot recreate / rebase not working
2 participants