Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues related with Dependabot::NpmAndYarn::UpdateChecker::LatestVersionFinder::RegistryError #10322

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Jul 31, 2024

What are you trying to accomplish?

Preface: fixes unhandled issues related with Dependabot::NpmAndYarn::UpdateChecker::LatestVersionFinder::RegistryError

Issues: These issues are related with raised exception RegistryError. The example of these exceptions are as following:

Got 503 response with body
Got 404 response with body
Got 405 response with body

Fix: Handle RegistryError exception and raise DependencyFileNotResolvable with valid message passed on to user.

+-------------------------------------------------------------------+
|                   Dependencies failed to update                   |
+---------------------------+---------------------------------------+
| package        | dependency_file_not_resolvable        |
+---------------------------+---------------------------------------+

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Jul 31, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 1, 2024 05:09
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 1, 2024 05:09
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dependabot-npm-and-yarn-update-latest-version-finder-registry-error branch from 6d309e9 to 0b7995e Compare August 1, 2024 15:51
@sachin-sandhu sachin-sandhu merged commit 7ea926f into main Aug 1, 2024
122 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/dependabot-npm-and-yarn-update-latest-version-finder-registry-error branch August 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants