Implement Logging for Bundler v1 Deprecation Errors and Warnings #10333
Conversation
| supported_versions: T::Array[String] | ||
| ).void | ||
| end | ||
| def record_deprecation_warning_for_eco_system( |
There was a problem hiding this comment.
wondering if we could pass the mode as an enum? E.g. as WARN or ERROR; that way we can reuse the same function.
There was a problem hiding this comment.
I will check that and I think it is possible and depends to how it is used it may be better solution.
There was a problem hiding this comment.
The code is moved #10466
| "Supported versions are: #{supported_versions.join(', ')}. Future updates are not guaranteed." | ||
| ) | ||
|
|
||
| service.record_update_job_error( |
There was a problem hiding this comment.
Wondering if we should refactor this by renaming the function to more accurately capture its intent? This can be a follow up PR though.
There was a problem hiding this comment.
Do you mean changing the service one or here. Actually in service we have this method which is sending the given params to API UI.
There was a problem hiding this comment.
The code is moved #10466
kbukum1
force-pushed
the
kamil/bundler_v1_deprecation_error
branch
from
44fa7e2
to
7cb269f
Compare
kbukum1
force-pushed
the
kamil/bundler_v1_deprecation_error
branch
from
2043b35
to
2c28cb7
Compare
kbukum1
force-pushed
the
kamil/bundler_v1_deprecation_error
branch
from
d73843f
to
d606d17
Compare
kbukum1
force-pushed
the
kamil/bundler_v1_deprecation_error
branch
from
d606d17
to
dac2832
Compare
|
The branch name is changed for implementing only deprecation warnings for bundler v1. |
Title: Implement Logging for Bundler v1 Deprecation Errors and Warnings
What are you trying to accomplish?
This PR introduces logging for deprecation warnings and errors specifically for Bundler v1. To achieve this, a generic framework is created in the
UpdateHelpersmodule that can be extended for other ecosystems in the future.Why:
This change ensures users are informed when using deprecated versions of Bundler and provides a structured approach for handling similar deprecations in other ecosystems.
Anything you want to highlight for special attention from reviewers?
The implementation includes:
UpdateHelpersmodule to log warnings and errors for deprecated versions.This approach allows for easy extension to other package managers in the future, ensuring consistency and maintainability.
How will you know you've accomplished your goal?
Checklist