Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentError Malformed version number in github actions #10338

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Aug 1, 2024

What are you trying to accomplish?

Reduce the number of malformed version errors in Sentry for github actions ecosystem.
Fix issue: https://github.com/github/dependabot-updates/issues/6446

More than 8k occurrences of this issue in Sentry and a large proportion of these were in the github actions ecosystem.

Within github actions, itself, there are also multiple use cases that lead to this issue. The fix in this PR is for the use cases where we create a security update PR (https://github.com/dependabot/dependabot-core/blob/main/updater/lib/dependabot/updater/operations/create_security_update_pull_request.rb#L98) or a group update PR: https://github.com/dependabot/dependabot-core/blob/main/updater/lib/dependabot/updater/operations/create_group_update_pull_request.rb#L61

Variations of this issue:
https://github.com/github/dependabot-updates/issues/6446

How will you know you've accomplished your goal?

Once this has been deployed. I expect zero occurrences of this issue from these use cases. This can be monitored in sentry.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe requested a review from a team as a code owner August 1, 2024 12:04
@github-actions github-actions bot added the L: github:actions GitHub Actions label Aug 1, 2024
@amazimbe amazimbe force-pushed the amazimbe/fix-malformed-versions-github-actions branch from 0af5ee4 to d4e8522 Compare August 2, 2024 07:56
@amazimbe amazimbe merged commit 2719454 into main Aug 2, 2024
54 checks passed
@amazimbe amazimbe deleted the amazimbe/fix-malformed-versions-github-actions branch August 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: github:actions GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants