Fixes JSON::ParserError: unexpected token issue #10381
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Preface: Related with
JSON::ParserError
issues.Issue: Private registry usually returns 200 code in case of successful response. The response contains package information as a JSON object. But it was observed that some private registries return 200 code with an HTML markup (usually for login). throws a
JSON::ParserError
in case of invalid JSON object.Fix: Identify if the response body being returned is valid JSON and raise proper exception in case invalid JSON.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist