Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Dependabot::SharedHelpers::HelperSubprocessFailed - ERR_PNPM_UNSUPPORTED_ENGINE #10419

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Aug 12, 2024

What are you trying to accomplish?

Preface: Fixes issues related with Dependabot::SharedHelpers::HelperSubprocessFailed - ERR_PNPM_UNSUPPORTED_ENGINE error in codebase

Issue: Issue raised when pnpm returned ERR_PNPM_UNSUPPORTED_ENGINE response while updating dependencies.

Fix: Add error handler to capture the error case and raise under Dependabot::ToolVersionNotSupported exception.


+------------------------------------------------------------------+
|                  Dependencies failed to update                   |
+-------------------------------------+----------------------------+
| @blocknote/core                     | tool_version_not_supported |
+-------------------------------------+----------------------------+

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 12, 2024 20:10
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 12, 2024 20:10
let(:version) { "0.15.4" }
let(:previous_version) { "0.15.3 " }
let(:requirements) do
[{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have more unit tests covering each possible branch in the original code?

@sachin-sandhu sachin-sandhu merged commit f71537d into main Aug 13, 2024
65 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/dependabot-shared-helpershelper_err_pnpm_unsupported_engine branch August 13, 2024 02:50
imajes pushed a commit to imajes/dependabot-core that referenced this pull request Sep 27, 2024
…SUPPORTED_ENGINE (dependabot#10419)

* adds exception handler for PNPM_UNSUPPORTED_ENGINE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants