Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pub workspaces #10445

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Aug 15, 2024

Dart 3.5 introduced support for "pub workspaces". (https://flutter.dev/go/pub-workspace)

This PR:

  • Updates dart to 3.5
  • Updates the dependency-services helper to fa941d583cd4952384d383fedf4bf4e472312249 with workspace support
  • Includes tests that a workspace can be updated.

Fixes dart-lang/pub#4291

@github-actions github-actions bot added the L: dart:pub Dart packages via pub label Aug 15, 2024
@sigurdm sigurdm marked this pull request as ready for review August 15, 2024 13:35
@sigurdm sigurdm requested a review from a team as a code owner August 15, 2024 13:35
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sigurdm ! It does seem like a flutter test is failing, do you mind taking a look please?

@sigurdm
Copy link
Contributor Author

sigurdm commented Aug 28, 2024

I updated all the tests with fresh fixtures. Seems we're good now. PTAL

@abdulapopoola
Copy link
Member

PTAL

Thanks @sigurdm , we'll try to get this deployed.

@thavaahariharangit thavaahariharangit merged commit 7e1007c into dependabot:main Aug 28, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dart:pub Dart packages via pub
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependabot_core to new version handling workspaces
3 participants