Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only discover dependencies from known project types #10451

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

brettfo
Copy link
Contributor

@brettfo brettfo commented Aug 15, 2024

When running NuGet dependency discovery, we should only process project types that are explicitly supported, namely .csproj, .vbproj, and .fsproj. This is consistent with how it's done elsewhere in this repo, we just missed a spot.

Fixes #10372

@github-actions github-actions bot added the L: dotnet:nuget NuGet packages via nuget or dotnet label Aug 15, 2024
@brettfo brettfo marked this pull request as ready for review August 15, 2024 23:35
@brettfo brettfo requested a review from a team as a code owner August 15, 2024 23:35
@kbukum1 kbukum1 force-pushed the dev/brettfo/nuget-restrict-file-extension branch from d15121d to 3da6d2a Compare August 16, 2024 02:01
@kbukum1 kbukum1 merged commit fa7da77 into main Aug 16, 2024
67 checks passed
@kbukum1 kbukum1 deleted the dev/brettfo/nuget-restrict-file-extension branch August 16, 2024 02:19
imajes pushed a commit to imajes/dependabot-core that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot update error when encountering a Visual Studio Installer project file (*.vdproj)
3 participants