-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds handler for YARN :: YN0xx errors #10505
Conversation
@@ -240,6 +254,12 @@ def self.sanitize_resolvability_message(error_message, dependencies, yarn_lock) | |||
Dependabot::MisconfiguredTooling.new("Yarn", message) | |||
} | |||
}, | |||
"YN0060" => { | |||
message: "Incompatible peer dependency", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think shouldbe handling this class of errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulapopoola , we can force resolve using --force or user can manually resolve the incompatibility. i wont recommend --force , i'm removing the handler for now and will look as part of this ongoing issue .
MANIFEST_NOT_FOUND: /YN0001: Error: (?<pkg>.*): Manifest not found/ | ||
FIND_PACKAGE_LOCATION: /YN0001:(.*?)UsageError: Couldn't find the (?<pkg>.*) state file/, | ||
NO_CANDIDATE_FOUND: /YN0001:(.*?)Error: (?<pkg>.*): No candidates found/, | ||
NO_SUPPORTED_RESOLVER: /YN0001:(.*?)Error: (?<pkg>.*) isn't supported by any available resolver/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where are these constants used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@abdulapopoola , they are used in YN0001 class of errors , as YN0001 is not a yarn error but application error, once we capture YN0001 , we evaluate it further to whether raise DependencyFileNotResolvable/ PrivateSourceAuthenticationFailure
/ parse errors etc. in case we cant find a match , we let it raise Dependabot::DependabotError
.
a1bebf4
to
3310515
Compare
What are you trying to accomplish?
Preface: Fixes issues related with YARN
Dependabot::DependabotError
errors.Issues: Yarn update response errors handling issues
Fixes: Adds exception handler for following Yarn codes:
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist