Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using existing branches #10519

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

Nishnha
Copy link
Member

@Nishnha Nishnha commented Aug 29, 2024

What are you trying to accomplish?

Avoid using existing branch names.

Anything you want to highlight for special attention from reviewers?

Receives a list of existing dependabot/ branches from API, and uses that to determine if the branch name requires a suffix.

How will you know you've accomplished your goal?

Dependabot will avoid opening a PR with an existing branch name and will instead append a suffix to the branch name.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@Nishnha Nishnha requested a review from a team as a code owner August 29, 2024 17:15
@Nishnha Nishnha self-assigned this Aug 29, 2024
@Nishnha Nishnha added the T: bug 🐞 Something isn't working label Aug 29, 2024
@Nishnha Nishnha force-pushed the nishnha/do-not-use-existing-branch branch from ab46cc9 to b211054 Compare August 29, 2024 18:19
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nishnha Nishnha force-pushed the nishnha/do-not-use-existing-branch branch from b211054 to 6299ed7 Compare September 3, 2024 16:43
@Nishnha Nishnha merged commit 90ecf22 into main Sep 5, 2024
123 checks passed
@Nishnha Nishnha deleted the nishnha/do-not-use-existing-branch branch September 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants