Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default to Bundler v2 when unsupported feature flag is on and Gemfile.lock exists #10617

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Sep 16, 2024

What are you trying to accomplish?

This PR updates the default behavior to use Bundler v2 when the bundler_v1_unsupported_error feature flag is enabled and a Gemfile.lock exists. If the Gemfile.lock does not specify the Bundler version, we will now default to Bundler v2 instead of v1 when the flag is active.

Anything you want to highlight for special attention from reviewers?

This change affects how dependencies are handled when there is no explicit Bundler version in the Gemfile.lock. With the feature flag enabled, the failover will be Bundler v2. This ensures compatibility with newer versions and prevents issues with unsupported Bundler v1.

How will you know you've accomplished your goal?

  • Bundler v2 is correctly used as the default when the bundler_v1_unsupported_error flag is enabled and the Gemfile.lock exists but lacks version information.
  • Dependencies update as expected using Bundler v2 under these conditions.
  • The feature flag controls the behavior as intended.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: ruby:bundler RubyGems via bundler label Sep 16, 2024
@kbukum1 kbukum1 marked this pull request as ready for review September 16, 2024 22:45
@kbukum1 kbukum1 requested a review from a team as a code owner September 16, 2024 22:45
@kbukum1 kbukum1 force-pushed the kamil/bundler_v1_unsupported_change_default_to_v2 branch from 7ff29de to 5535cf9 Compare September 17, 2024 15:31
@abdulapopoola
Copy link
Member

Thanks @kbukum1 , how are we planning to test this change?

@kbukum1
Copy link
Contributor Author

kbukum1 commented Sep 17, 2024

Thanks @kbukum1 , how are we planning to test this change?

Before i plan to deploy this change with #10601. Since they are behind the feature flag, I am planing to activate them and test together on 3 different repos

  • A repository that doesn't have bundler version
  • A repository that has specified bundler v1 version.
  • A repository that has specified bundler v2 version.

@kbukum1 kbukum1 merged commit 95f169b into main Sep 17, 2024
59 checks passed
@kbukum1 kbukum1 deleted the kamil/bundler_v1_unsupported_change_default_to_v2 branch September 17, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: ruby:bundler RubyGems via bundler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants