Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes exception handler for file_not_parseable under file_updater and fixes error handler for package not found error #10619

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Sep 17, 2024

What are you trying to accomplish?

Preface: Fixes issues related with Dependabot::SharedHelpers::HelperSubprocessFailed

Issues: Issues as following:

  1. Exceptions related with malformed package.json.
  2. Unhandled issue when package name is omitted from registry resulting in unhandled exception

Fix:

  1. Aligns exception class to be more suitable with file updater class of errors.
  2. Adds handler to handle scenario of null package name specified in dependency.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu changed the title adds exception handler for file not parsebale and corrects use case f… Fixes exception handler for file_not_parseable under file_updater and fixes error handler for package not found error Sep 20, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review September 23, 2024 21:53
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner September 23, 2024 21:53

it "raises a helpful error" do
expect { updated_pnpm_lock_content }
.to raise_error(Dependabot::PrivateSourceAuthenticationFailure)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this new error thrown? I don't see the changes in this pR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants