Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert smoke test branch back to main #10630

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Sep 18, 2024

What are you trying to accomplish?

Changing the smoke test branch back to main now that the feature branch has been merged.

It fixes build failures that are a result of the missing feature branch.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe merged commit 90257e9 into main Sep 18, 2024
123 checks passed
@amazimbe amazimbe deleted the amazimbe/update-smoke-test-branch branch September 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants