Strict type Dependabot::Terraform::RegistryClient
#10643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
jamiemagee/terraform-registry-client
branch
from
ca91212
to
2350f73
Compare
JamieMagee
commented
Sep 20, 2024
| @@ -241,7 +241,7 @@ def git_source_details_from(source_string) | |||
| if git_url.include?("git@") | |||
| git_url.split("git@").last.sub(":", "/") | |||
| else | |||
| git_url.sub(%r{.*?://}, "") | |||
| git_url.sub(%r{(?:\w{3,5})?://}, "") | |||
There was a problem hiding this comment.
This fixed the CodeQL issue that was flagged. All protocols git allowes are betwen 3 and 5 characters: git, ssh, http, https, file.
JamieMagee
force-pushed
the
jamiemagee/terraform-registry-client
branch
from
7b4d89b
to
32b9cdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Strict type
Dependabot::Terraform::RegistryClientAnything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
Checklist