Add Docker image bumping for .drone.yml files #1447
Conversation
| @@ -556,7 +556,7 @@ | |||
| context "with a non-standard filename" do | |||
| let(:dockerfile) do | |||
| Dependabot::DependencyFile.new( | |||
| name: "custom-name", | |||
| name: "custom-dockerfile-name", | |||
There was a problem hiding this comment.
I was confused by the initial test here. A 'dockerfile' with a name 'custom-name' should never have been picked up by the file_fetcher code which, if I understand correctly, is what will feed the parser code. So the string 'dockerfile' should be in the name somewhere to be picked up and that is what this change is doing and what the larger code change in general uncovered.
Could you confirm?
JimNero009
changed the title
|
@JimNero009 👋 Thanks for submitting this! The team is pretty busy scaling Dependabot for GitHub, so it will be a while before we can get to reviewing this. |
JimNero009
force-pushed
the
drone-support
branch
from
467b196 to
707c7d2
Compare
|
@JimNero009 hey sorry dropping this! Unfortunately can't accept this change as any new package manager makes it harder to debug and maintain for the team which is very under-resourced at the moment 😢 We're hoping to onboard a few more people over the coming months and I'm keen to figure out a plan of supporting community package managers, possibly through a plugin system of sorts. We've also moved towards separating package managers, e.g. |
|
@JimNero009 what are your thoughts on building drone support as a separate gem, e.g. You'll then want to require in from your self hosted script, e.g. You'll want to add a dependency on We could then look at moving generic parts to common if this would help you out over time to make it easier to write custom dependabot-gems. Would be ace if all the basic blocks existed to throw together a language with minimal plumbing, supporting this: #1290 |
|
Sounds like a decent plan! Can't promise I'll get to it any time soon, but I will keep it in mind for those lazy Christmas holidays. |
Drone is a CI system that defines a set of steps, each of which contains a Docker image that determines in what container a set of commands should be run. Those images should be fixed for reproducible builds and be updated over time in the same way a Dockerfile should be. This PR then extends the Docker bumping functionality to also include the .drone.yml file and regex replace images as appropriate.