Go modules: raise GitDependenciesNotReachable #2780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
reviewed
Nov 23, 2020
jurre
reviewed
Nov 23, 2020
jurre
approved these changes
Nov 23, 2020
thepwagner
force-pushed
the
go-modules-git-dependency-not-reachable
branch
from
3eef9a1
to
6f2277a
Compare
thepwagner
commented
Nov 24, 2020
jurre
approved these changes
Nov 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing snapshot to discuss the approach:
When Dependabot encounters a Go module backed by a Git repository, especially one on
github.com, it should raiseDependabot::GitDependenciesNotReachablewithdependency-urlsdetails describing the missing repository. This matters as the rich exception provides more detail about what went wrong and potential recovery options.This PR accomplishes this by intercepting the error thrown from the "UpdateChecker", and detecting
github.com/.*urls. If we detect the failed dependency was ongit.luolix.top, we assume it's a "git dependency" and raise accordingly.