Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop requirement from ~> 1.8.0 to ~> 1.9.0 in /common #3055

Merged
merged 1 commit into from
Jan 29, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2021

Updates the requirements on rubocop to permit the latest version.

Release notes

Sourced from rubocop's releases.

RuboCop 1.9

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. (@koic)
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. (@koic)
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. (@dvandersluis)
  • #9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. (@koic)
  • #9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. (@dvandersluis)
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. (@asterite)
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection to not change variables if the exception variable has been reassigned. (@dvandersluis)
  • #9389: Fix an infinite loop error for IncludeSemanticChanges: false of Style/NonNilCheck with EnforcedStyle: comparison of Style/NilComparison. (@koic)
  • #9384: Fix a suggestion message when not auto-correctable. (@koic)
  • #9424: Fix an incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor. (@koic)
  • #9370: Fix an incorrect auto-correct for Style/SoleNestedConditional when using nested unless modifier multiple conditional. (@koic)
  • #9406: Fix rubocop_todo link injection when YAML doc start sigil exists. (@dduugg)
  • #9229: Fix errors being reported with rubocop -V with an invalid config. (@dvandersluis)
  • #9425: Fix error in Layout/ClassStructure when initializer comes after private attribute macro. (@tejasbubane)

Changes

  • #9415: Change Layout/ClassStructure to detect inline modifiers. (@AndreiEres)
  • #9380: Mark Style/FloatDivision as unsafe. (@koic)
  • #9345: Make Style/AsciiComments allow copyright notice by default. (@koic)
  • #9399: Added AllowedCops configuration to Style/DisableCopsWithinSourceCodeDirective. (@dvandersluis)
  • #9327: Change Layout/EmptyLineAfterMagicComment to accept top-level shareable_constant_values directive. (@tejasbubane)
  • #7902: Change Lint/NumberConversion to detect symbol form of conversion methods. (@tejasbubane)
Changelog

Sourced from rubocop's changelog.

1.9.0 (2021-01-28)

New features

Bug fixes

  • #9366: Fix an incorrect auto-correct for Style/SoleNestedConditional when using method arguments without parentheses for outer condition. ([@koic][])
  • #9372: Fix an error for Style/IfInsideElse when nested if branch code is empty. ([@koic][])
  • #9374: Fix autocorrection for Layout/LineLength when the first argument to a send node is a overly long hash pair. ([@dvandersluis][])
  • #9387: Fix incorrect auto-correct for Style/NilComparison when using !x.nil? and EnforcedStyle: comparison. ([@koic][])
  • #9411: Fix false negatives for Style/EvalWithLocation for Kernel.eval and when given improper arguments. ([@dvandersluis][])
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection when the rescue body returns the exception variable. ([@asterite][])
  • #7766: Fix Naming/RescuedExceptionsVariableName autocorrection to not change variables if the exception variable has been reassigned. ([@dvandersluis][])
  • #9389: Fix an infinite loop error for IncludeSemanticChanges: false of Style/NonNilCheck with EnforcedStyle: comparison of Style/NilComparison. ([@koic][])
  • #9384: Fix a suggestion message when not auto-correctable. ([@koic][])
  • #9424: Fix an incorrect auto-correct for Style/ClassMethodsDefinitions when defining class methods with class << self and there is no blank line between method definition and attribute accessor. ([@koic][])
  • #9370: Fix an incorrect auto-correct for Style/SoleNestedConditional when using nested unless modifier multiple conditional. ([@koic][])
  • #9406: Fix rubocop_todo link injection when YAML doc start sigil exists. ([@dduugg][])
  • #9229: Fix errors being reported with rubocop -V with an invalid config. ([@dvandersluis][])
  • #9425: Fix error in Layout/ClassStructure when initializer comes after private attribute macro. ([@tejasbubane][])

Changes

  • #9415: Change Layout/ClassStructure to detect inline modifiers. ([@AndreiEres][])
  • #9380: Mark Style/FloatDivision as unsafe. ([@koic][])
  • #9345: Make Style/AsciiComments allow copyright notice by default. ([@koic][])
  • #9399: Added AllowedCops configuration to Style/DisableCopsWithinSourceCodeDirective. ([@dvandersluis][])
  • #9327: Change Layout/EmptyLineAfterMagicComment to accept top-level shareable_constant_values directive. ([@tejasbubane][])
  • #7902: Change Lint/NumberConversion to detect symbol form of conversion methods. ([@tejasbubane][])

1.8.1 (2021-01-11)

Bug fixes

  • #9342: Fix an error for Lint/RedundantDirGlobSort when using collection.sort. ([@koic][])
  • #9304: Do not register an offense for Style/ExplicitBlockArgument when the yield arguments are not an exact match with the block arguments. ([@dvandersluis][])
  • #8281: Fix Style/WhileUntilModifier handling comments and assignment when correcting to modifier form. ([@Darhazer][])
  • #8229: Fix faulty calculation in UncommunicativeName. ([@ohbarye][])
  • #9350: Wrap in parens before replacing unless with if and !. ([@magneland][])
  • #9356: Fix duplicate extension cop versions when using rubocop -V. ([@koic][])
  • #9355: Fix Style/SingleLineMethods autocorrection to endless method when the original code had parens. ([@dvandersluis][])

... (truncated)

Commits
  • c95412e Cut 1.9.0
  • bd20cc7 Update Changelog
  • 160e5df Fix an incorrect auto-correct for Style/ClassMethodsDefinitions
  • ad85a55 Add new InternalAffairs/RedundantLetRuboCopConfigNew cop
  • e916e9a Merge pull request #9426 from tejasbubane/fix-9425
  • 39b9f82 [Fix #9425] Fix error in Layout/ClassStructure when initializer comes after...
  • 4356728 Fix false negatives for Style/EvalWithLocation for Kernel.eval and when g...
  • 1f7d2d2 [Fix #9415] Change Layout/ClassStructure to detect inline modifiers
  • 9a06e84 Fix InternalAffairs/ExampleDescription offenses.
  • c37b550 Add new InternalAffairs/ExampleDescription cop.
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [rubocop](https://github.com/rubocop-hq/rubocop) to permit the latest version.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.8.0...v1.9.0)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner January 29, 2021 05:07
@dependabot dependabot bot added dependencies ruby Dependabot pull requests that update Ruby code labels Jan 29, 2021
@jurre jurre merged commit bf2a3ba into main Jan 29, 2021
@jurre jurre deleted the dependabot/bundler/common/rubocop-tw-1.9.0 branch January 29, 2021 10:48
feelepxyz added a commit that referenced this pull request Apr 16, 2021
Changes since 7.7.4: https://github.com/npm/cli/blob/latest/CHANGELOG.md

## v7.10.0 (2021-04-15)

### FEATURES

* [`f9b639eb6`](npm/cli@f9b639e)
  [#3052](npm/cli#3052)
  feat(bugs): fall back to email if provided
  ([@Yash-Singh1](https://github.com/Yash-Singh1))
* [`8c9e24778`](npm/cli@8c9e247)
  [#3055](npm/cli#3055)
  feat(version): add workspace support
  ([@wraithgar](https://github.com/wraithgar))

### DEPENDENCIES

* [`f1e6743a6`](npm/cli@f1e6743)
  `libnpmversion@1.2.0`
    * feat(retrieve-tag): retrieve unannotated git tags
    * fix(retrieve-tag): use semver to look for semver
* [`3b476a24c`](npm/cli@3b476a2)
  `@npmcl/git@2.0.8`
    * fix(git): do not use shell when calling git
* [`dfcd0c1e2`](npm/cli@dfcd0c1)
  [#3069](npm/cli#3069)
  `tap@15.0.2`

### DOCUMENTATION

* [`90b61eda9`](npm/cli@90b61ed)
  [#3053](npm/cli#3053)
  fix(contributing.md): explicitely outline dep updates
  ([@darcyclarke](https://github.com/darcyclarke))

## v7.9.0 (2021-04-08)

### FEATURES

* [`1f3e88eba`](npm/cli@1f3e88e)
  [#3032](npm/cli#3032)
  feat(dist-tag): add workspace support
  ([@nlf](https://github.com/nlf))
* [`6e31df4e7`](npm/cli@6e31df4)
  [#3033](npm/cli#3033)
  feat(pack): add workspace support
  ([@wraithgar](https://github.com/wraithgar))

### DEPENDENCIES

* [`ba4f7fea8`](npm/cli@ba4f7fe)
  `licensee@8.2.0`

## v7.8.0 (2021-04-01)

### FEATURES


* [`8bcc5d73f`](npm/cli@8bcc5d7)
  [#2972](npm/cli#2972)
  feat(workspaces): add repo and docs
  ([@wraithgar](https://github.com/wraithgar))
* [`ec520ce32`](npm/cli@ec520ce)
  [#2998](npm/cli#2998)
  feat(set-script): implement workspaces
* [`32717a60e`](npm/cli@32717a6)
  [#3001](npm/cli#3001)
  feat(view): add workspace support
  ([@wraithgar](https://github.com/wraithgar))
* [`7b177e43f`](npm/cli@7b177e4)
  [#3014](npm/cli#3014)
  feat(config): add 'envExport' flag
  ([@isaacs](https://github.com/isaacs))

### BUG FIXES

* [`4c4252348`](npm/cli@4c42523)
  [#3016](npm/cli#3016)
  fix(usage): specify the key each time for multiples
  ([@isaacs](https://github.com/isaacs))
* [`9237d375b`](npm/cli@9237d37)
  [#3013](npm/cli#3013)
  fix(docs): add workspaces configuration
  ([@wraithgar](https://github.com/wraithgar))
* [`cb6eb0d20`](npm/cli@cb6eb0d)
  [#3015](npm/cli#3015)
  fix(ERESOLVE): better errors when current is missing
  ([@isaacs](https://github.com/isaacs))

### DEPENDENCIES

* [`61da39beb`](npm/cli@61da39b)
  `@npmcli/config@2.1.0`
  * feat(config): add support for envExport:false
* [`fb095a708`](npm/cli@fb095a7)
  `@npmcli/arborist@2.3.0`:
  * [#2896](npm/cli#2896) Provide currentEdge in
  ERESOLVE if known, and address self-linking edge case.
  * Add/remove dependencies to/from workspaces when set, not root project
  * Only reify the portions of the dependency graph identified by the
  `workspace` configuration value.
  * Do not recursively `chown` the project root path.

## v7.7.6 (2021-03-29)

### BUG FIXES

* [`9dd2ed518`](npm/cli@9dd2ed5)
  fix empty newline printed to stderr
  ([@ruyadorno](https://github.com/ruyadorno))
* [`9d391462a`](npm/cli@9d39146)
  [#2973](npm/cli#2973)
  fix spelling in workspaces.md file
  ([@sethomas](https://github.com/sethomas))
* [`4b100249a`](npm/cli@4b10024)
  [#2979](npm/cli#2979)
  change 'maxsockets' default value back to 15
  ([@wallrat](https://github.com/wallrat))

### DEPENDENCIES

* [`a28f89572`](npm/cli@a28f895)
  `libnpmversion@1.1.0`
    * fix reading `script-shell` config on `npm version` lifecycle scripts
* [`03734c29e`](npm/cli@03734c2)
  `npm-packlist@2.1.5`
    * fix packaging `bundledDependencies`
* [`80ce2a019`](npm/cli@80ce2a0)
  `@npmcli/metavuln-calculator@1.1.1`
    * fix error auditing package documents with missing dependencies

## v7.7.5 (2021-03-25)

### BUG FIXES

* [`95ba87622`](npm/cli@95ba876)
  [#2949](npm/cli#2949)
  fix handling manual indexes in `npm help`
  ([@dmchurch](https://github.com/dmchurch))
* [`59cf37962`](npm/cli@59cf379)
  [#2958](npm/cli#2958)
  always set `npm.command` to canonical command name
  ([@isaacs](https://github.com/isaacs))
* [`1415b4bde`](npm/cli@1415b4b)
  [#2964](npm/cli#2964)
  fix(config): properly translate user-agent
  ([@wraithgar](https://github.com/wraithgar))
* [`59271936d`](npm/cli@5927193)
  [#2965](npm/cli#2965)
  fix(config): tie save-exact/save-prefix together
  ([@wraithgar](https://github.com/wraithgar))

### TESTS

* [`97b415287`](npm/cli@97b4152)
  [#2959](npm/cli#2959)
  add smoke tests
  ([@ruyadorno](https://github.com/ruyadorno))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Dependabot pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant