Use the correct Docker digest when checking for updates #3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurre
force-pushed
the
jurre/use-correct-docker-digest
branch
from
c2d393f
to
5fa6576
Compare
feelepxyz
reviewed
Feb 2, 2021
jurre
force-pushed
the
jurre/use-correct-docker-digest
branch
from
5fa6576
to
e437258
Compare
Previously, Dependabot would use the [Docker registry manifest endpoint](https://docs.docker.com/registry/spec/api/#manifest) with the `application/vnd.docker.distribution.manifest.v2+json` Media Type: ``` dt=$(curl "https://auth.docker.io/token?service=registry.docker.io&scope=repository:library/python:pull" | jq -r .access_token) curl curl --get -v https://registry.hub.docker.com:443/v2/library/python/manifests/slim --header "Authorization: Bearer $dt" --header "Accept: application/vnd.docker.distribution.manifest.v2+json" < HTTP/1.1 200 OK < Content-Length: 1370 < Content-Type: application/vnd.docker.distribution.manifest.v2+json < Docker-Content-Digest: sha256:af2d64e6de9f891bd5958a498bd2394389143749b3c57ffcc8c2aec054b28ad5 ``` However, the digest that is returned in the header here, is actually that of the first platform that's listed. When we install that latest image, we see the digest should actually be: ``` docker images --digests | grep python python slim sha256:50328b4efe5ff8ef8bb2e62e088a4cefeace39062c483c04987f5820e7cf73b1 ``` When using the `application/vnd.docker.distribution.manifest.list.v2+json` media type: ``` dt=$(curl "https://auth.docker.io/token?service=registry.docker.io&scope=repository:library/python:pull" | jq -r .access_token) curl curl --get -v https://registry.hub.docker.com:443/v2/library/python/manifests/slim --header "Authorization: Bearer $dt" --header "Accept: application/vnd.docker.distribution.manifest.list.v2+json" < HTTP/1.1 200 OK < Content-Length: 1862 < Content-Type: application/vnd.docker.distribution.manifest.list.v2+json < Docker-Content-Digest: sha256:50328b4efe5ff8ef8bb2e62e088a4cefeace39062c483c04987f5820e7cf73b1 ``` We get the expected digest, and when inspecting the body, we can see that we previously got the digest for amd64: ```json { "manifests": [ { "digest": "sha256:af2d64e6de9f891bd5958a498bd2394389143749b3c57ffcc8c2aec054b28ad5", "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "platform": { "architecture": "amd64", "os": "linux" }, "size": 1370 }, ``` The tests have remained unchanged in this PR, because (unfortunately) all the requests and responses are stubbed out.
jurre
force-pushed
the
jurre/use-correct-docker-digest
branch
from
e437258
to
58b2624
Compare
feelepxyz
approved these changes
Feb 2, 2021
Yeah, good shout. I'll open an issue to see what they think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Dependabot would use the Docker registry manifest
endpoint with the
application/vnd.docker.distribution.manifest.v2+jsonMedia Type:However, the digest that is returned in the header here, is actually
that of the first platform that's listed.
When we install that latest image, we see the digest should actually be:
When using the
application/vnd.docker.distribution.manifest.list.v2+jsonmedia type:We get the expected digest, and when inspecting the body, we can see
that we previously got the digest for amd64:
{ "manifests": [ { "digest": "sha256:af2d64e6de9f891bd5958a498bd2394389143749b3c57ffcc8c2aec054b28ad5", "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "platform": { "architecture": "amd64", "os": "linux" }, "size": 1370 },The tests have remained unchanged in this PR, because (unfortunately)
all the requests and responses are stubbed out.
Fixes #2962