Refactor NpmLockfileUpdater #3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feelepxyz
commented
Feb 10, 2021
| @@ -1,11 +1,11 @@ | |||
| { | |||
| "name": "{{ name }}", | |||
| "name": "project-name", | |||
There was a problem hiding this comment.
This is more realistic example where the lockfile has a "valid" generated name by some build step, we make sure to restore this name, not the invalid name in the package.json, the code to restore this hasn't changed
Extracting a refactor from #3106 Initialize the lockfile updater with a lockfile being updated removing the need to pass around the lockfile everywhere. A few spec changes have snuck in from the above pr but these should be cosmetic as no fuctionality has changed.
feelepxyz
force-pushed
the
feelepxyz/refactor-npm-lockfile-updater
branch
from
0cd7ae2 to
448fbce
Compare
jurre
approved these changes
Feb 10, 2021
This was referenced Feb 6, 2024
This was referenced Feb 28, 2024
This was referenced Mar 17, 2024
This was referenced Apr 11, 2024
Closed
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a refactor from
#3106
Initialize the lockfile updater with a lockfile being updated removing
the need to pass around the lockfile everywhere.
A few spec changes have snuck in from the above pr but these should be
cosmetic as no fuctionality has changed.