Use project fixtures for FileUpdater specs #3400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brrygrdn
commented
Mar 29, 2021
| @@ -27,6 +27,10 @@ def bundler_project_dependency_file(project, filename:) | |||
| dependency_file | |||
| end | |||
|
|
|||
| def bundler_build_tmp_repo(project) | |||
| build_tmp_repo(project, path: "projects/bundler1") | |||
There was a problem hiding this comment.
This is hard-coded to bundler1, it'll switch based on the suite name in #3350
feelepxyz
reviewed
Mar 29, 2021
| let(:gemfile_body) { fixture("ruby", "gemfiles", gemfile_fixture_name) } | ||
| let(:lockfile_body) { fixture("ruby", "lockfiles", lockfile_fixture_name) } | ||
| let(:gemfile_fixture_name) { "Gemfile" } | ||
| let(:lockfile_fixture_name) { "Gemfile.lock" } |
brrygrdn
force-pushed
the
brrygrdn/file_updater_proj_fixtures
branch
from
299f679
to
fb81286
Compare
|
🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaks out from #3350