Bundler 2 [pre-release]: Run the entire bundler test suite with v2 Gemfile.lock fixtures #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the last commit fixes some test failures I have locally in |
feelepxyz
approved these changes
Mar 30, 2021
brrygrdn
force-pushed
the
brrygrdn/test-bundler2-with-separate-fixtures
branch
from
6a4290b
to
332c3e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts from #3350
This PR adds a helper method with checks the correct project folder depending on whether the test suite is targeting bundler1 or bundler2.
This ensures that we use Gemfile.lock fixtures that have appropriate
BUNDLED WITHstrings to ensure we correctly detect and handle them with the correct wrapped native bundler in future.